-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add assumerole #24
base: devel
Are you sure you want to change the base?
Add assumerole #24
Conversation
@thedoubl3j It should be possible to rebase now. Check what jobs are green on |
67de58a
to
af9404e
Compare
FYI, PEP 257-compliant docstrings are always made of triple double-quotes. |
cfeb4c8
to
5266f82
Compare
@thedoubl3j plz also add the entry point to the smoke test params @ https://github.com/ansible/awx-plugins/blob/82c8c95/tests/importable_test.py#L27-L73 |
Rebase this. From now on, all the GHA checks are expected to show up green. |
An alternative would be to add a `from __future__ import annotations` for lazy evaluation.
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
3d17a14
to
cbeea1c
Compare
@thedoubl3j this will end up in https://github.com/ansible/awx_plugins.credential.aws_assumerole eventually. That repo doesn't yet have Git history, but it will. Still, it's useful to do an interactive rebase with the commit cleanup here and fix the conflicts. This will help re-graft this branch into the new repo. |
Adding in the AWS assume role cred plugin authored by @derekwaters found in this AWX PR.