fix: ensure database settings printed in startup logging (#1316)

We have detected issues with the current code in startup logging where
the database settings are not printed. The current code has a bug where
we assumed the databases object would be a `box` object provided by
dynaconf, but it is actually a dict, so it never will have attributes.
This code fixes the issue and ensures the database settings are printed.

Signed-off-by: Alex <[email protected]>

Author: Alex-Izquierdo

src/aap_eda/utils/logging.py

@@ -101,13 +101,13 @@ def startup_logging(logger: logging.Logger) -> None:
 
     # Database settings
     unconditional_logger.log("  Default database:")
+    if not settings.DATABASES or not settings.DATABASES.get("default"):
+        logger.error(
+            "Expected setting DATABASES not found or empty",
+        )
     for setting in ["USER", "HOST", "PORT", "OPTIONS"]:
-        if hasattr(settings.DATABASES["default"], setting):
-            unconditional_logger.log(
-                f"    {setting}: "
-                f"{getattr(settings.DATABASES['default'], setting)}",
-            )
-
+        value = settings.DATABASES["default"].get(setting)
+        unconditional_logger.log(f"    {setting}: {value}")
     # Resource server is relevant but can contain sensitive information
     resource_server = settings.RESOURCE_SERVER.get("URL")
     unconditional_logger.log(f"  Resource server: {resource_server}")

tests/integration/test_logging.py

@@ -20,6 +20,10 @@ def test_http_startup_logging(caplog_factory, module):
 
     assert "Starting eda-server" in caplog.text
 
+    # hardcoded value to not depends on settings
+    # and be able to handle unexpected lookups
+    assert "HOST: localhost" in caplog.text
+
 
 def test_worker_startup_logs():
     """