-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add an exception if executable not found #184
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The message of the exception isn't actionable by the end user
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - although we could actively check for None as well. But this is more than enough
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. But I think the message could be more explicative.
Co-authored-by: German <[email protected]>
Currently, if no executable found in default location when using
get_mechanical_path
, then we are returningNone
. This is causing issue when we callversion_from_path
where we givepath
as input. We do not have any check if path is None.Alternately we can avoid this exception and return
path
as empty string (as it is) it is instead ofNone
. If that is the case thenversion_from_path
will take care of value error ifpath
isempty string