Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Setup classes #5709

Open
Devin-Crawford opened this issue Jan 31, 2025 · 0 comments
Open

Improve Setup classes #5709

Devin-Crawford opened this issue Jan 31, 2025 · 0 comments
Assignees
Labels
enhancement New features or code improvements

Comments

@Devin-Crawford
Copy link
Contributor

Description of the current limitations

The SetupHFSS, SetupQ3D and other setup class definitions have a common method add_sweep() that has redundant code. This method should be defined in the base class CommonSetup and be inherited by the other setup classes.

Code sample expected

The details of implementation will have to consider the nuances of the different syntax in the native API for the different possible sweep setups. See for example the add_sweep methods in the setups and modifications made in PR #5683 .

Useful links and references

See aedt\core\modules\solve_sweeps.py SweepMatrix or SweepHFSS class definitions.

@Devin-Crawford Devin-Crawford added the enhancement New features or code improvements label Jan 31, 2025
@Devin-Crawford Devin-Crawford self-assigned this Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements
Projects
None yet
Development

No branches or pull requests

1 participant