Skip to content

feat: Streaming upload support #1779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 72 commits into from
Mar 16, 2025
Merged

feat: Streaming upload support #1779

merged 72 commits into from
Mar 16, 2025

Conversation

mlkaplan36
Copy link
Contributor

@mlkaplan36 mlkaplan36 commented Feb 25, 2025 •
edited
Loading

Description

Client side support for streaming files to/from the server.
Client side support for streaming tessellation from the server.

Issue linked

Closes #1765, #1778

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@mlkaplan36 mlkaplan36 self-assigned this Feb 25, 2025
@github-actions github-actions bot added the enhancement New features or code improvements label Feb 25, 2025
This was linked to issues Feb 26, 2025
Error on opening a cad file with size ~280 MB #1765
Closed
Enable streaming for upload/download of file #1778
Closed
mlkaplan36 and others added 11 commits February 26, 2025 09:09
@mlkaplan36
Add support for streaming a file download
9385ba2
@mlkaplan36
Merge branch 'feat/streaming_upload_support' of https://github.com/an…
8c498ea 
…sys/pyansys-geometry into feat/streaming_upload_support
@pre-commit-ci
chore: auto fixes from pre-commit hooks
5bf9eec
@mlkaplan36
Use MAX_MESSAGE_LENGTH to determine chunk size
cd8aa59
@mlkaplan36
Add support for streaming tessellation
b2751b7
@pre-commit-ci
chore: auto fixes from pre-commit hooks
f66562c
@mlkaplan36
Adapt max message size to account for gRPC message overhead
353851a
@mlkaplan36
Merge branch 'feat/streaming_upload_support' of https://github.com/an…
d9c1c35 
…sys/pyansys-geometry into feat/streaming_upload_support
@pre-commit-ci
chore: auto fixes from pre-commit hooks
87a5e51
@mlkaplan36
Merge branch 'main' of https://github.com/ansys/pyansys-geometry into…
bb84ad0 
… feat/streaming_upload_support
@RobPasMue
ci: simplify blitz ci
b827101
@mlkaplan36 mlkaplan36 changed the base branch from main to blitz March 10, 2025 13:42
@github-actions GitHub Actions
Copy link

The towncrier template has been successfully rewritten with the default template.
Please ensure that sphinx-design is included as a dependency in your project's documentation requirements.
Additionally, add sphinx-design to the extensions list in your conf.py file.
For more information, please refer to the migration guide at:
https://actions.docs.ansys.com/version/stable/migrations/index.html#migration-guide

@codecov Codecov
Copy link

codecov bot commented Mar 10, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 57.44681% with 40 lines in your changes missing coverage. Please review.

Project coverage is 90.17%. Comparing base (04ffd1b) to head (e91856e).
Report is 1 commits behind head on blitz.

Files with missing lines Patch % Lines
src/ansys/geometry/core/designer/body.py 32.00% 17 Missing ⚠️
src/ansys/geometry/core/misc/options.py 60.00% 10 Missing ⚠️
src/ansys/geometry/core/designer/design.py 45.45% 6 Missing ⚠️
src/ansys/geometry/core/modeler.py 76.92% 6 Missing ⚠️
src/ansys/geometry/core/connection/launcher.py 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##            blitz    #1779      +/-   ##
==========================================
- Coverage   90.51%   90.17%   -0.35%     
==========================================
  Files          92       92              
  Lines        8727     8801      +74     
==========================================
+ Hits         7899     7936      +37     
- Misses        828      865      +37

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mlkaplan36 mlkaplan36 requested a review from RobPasMue March 14, 2025 14:01
RobPasMue
RobPasMue reviewed Mar 14, 2025
View reviewed changes
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good @mlkaplan36 - thanks a lot for the changes. One small naming change and a reordering request, and should be good to go

@RobPasMue RobPasMue enabled auto-merge (squash) March 14, 2025 15:55
@mlkaplan36
Copy link
Contributor Author

@RobPasMue - the failing test in Windows (core-windows-latest, false) passes for me locally, so I'm not sure what the issue could be there.

FAILED tests/integration/test_design.py::test_stream_upload_file - grpc._channel._InactiveRpcError: <_InactiveRpcError of RPC that terminated with:
status = StatusCode.UNKNOWN
details = "Exception was thrown by handler."
debug_error_string = "UNKNOWN:Error received from peer ipv4:127.0.0.1:700 {grpc_message:"Exception was thrown by handler.", grpc_status:2, created_time:"2025-03-14T18:18:09.5653957+00:00"}"

@RobPasMue
Copy link
Member

Let me investigate it next week @mlkaplan36 - if it passes locally for you, it might be a runner (CI/CD) issue

RobPasMue
RobPasMue approved these changes Mar 16, 2025
View reviewed changes
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving - although further streaming testing is definitely needed. Pinging @RyanJWard to see if he can help on that task. We'll merge as is for now.

@RobPasMue RobPasMue disabled auto-merge March 16, 2025 16:23
@RobPasMue RobPasMue merged commit 3bea3ed into blitz Mar 16, 2025
24 of 25 checks passed
@RobPasMue RobPasMue deleted the feat/streaming_upload_support branch March 16, 2025 16:43
@RobPasMue RobPasMue mentioned this pull request Mar 19, 2025
Closed
@RobPasMue RobPasMue linked an issue Apr 14, 2025 that may be closed by this pull request
Plot/tesselate not working on geometry #1329
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobPasMue RobPasMue RobPasMue approved these changes

@RyanJWard RyanJWard RyanJWard approved these changes

@jonahrb jonahrb Awaiting requested review from jonahrb

@jacobrkerstetter jacobrkerstetter Awaiting requested review from jacobrkerstetter

@jrwest440 jrwest440 Awaiting requested review from jrwest440

Assignees

@mlkaplan36 mlkaplan36

Labels
enhancement New features or code improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Plot/tesselate not working on geometry Enable streaming for upload/download of file Error on opening a cad file with size ~280 MB
5 participants
@mlkaplan36 @RobPasMue @RyanJWard @pyansys-ci-bot @umutsoysalansys