Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: support ssr for improve seo #1257

Merged
merged 14 commits into from
Nov 28, 2024
Merged

docs: support ssr for improve seo #1257

merged 14 commits into from
Nov 28, 2024

Conversation

yutingzhao1991
Copy link
Collaborator

@yutingzhao1991 yutingzhao1991 commented Nov 20, 2024 •
edited
Loading

添加 dumi ssr 配置，提升首页渲染速度和 SEO close #1212

修改的内容点有：

  • 首页内容直接挪到 pages/index 中，避免文档加载导致的 loading，对应的 components 也放到了 .dumi/componenets 下面。
  • dumi 配置中打开 ssr，对应构建文档时 react 版本改为 [email protected]（18.3.1 有问题）
  • 把一些 demo 中涉及到 window 直接使用的地方加上 typeof 判断，避免 pre render 的时候报错
  • 升级了一下 vitest（不是必须的，但是调试的时候就正好升级了）
  • 去掉 sui demo 中的 queryClient 配置，它会导致服务端构建的时候超时

@vercel Vercel
Copy link

vercel bot commented Nov 20, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ant-design-web3 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 27, 2024 0:44am

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 20, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: fb77f86

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 20, 2024 •
edited
Loading

Preview is ready

@socket-security Socket Security
Copy link

socket-security bot commented Nov 20, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher

🚮 Removed packages: npm/@umijs/[email protected]

View full report↗︎

thinkasany
thinkasany reviewed Nov 20, 2024
View reviewed changes
.dumi/pages/index/components/ShowCase/index.tsx Outdated Show resolved Hide resolved
.dumirc.ts Outdated Show resolved Hide resolved
@codecov Codecov
Copy link

codecov bot commented Nov 27, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.99%. Comparing base (65c86c5) to head (fb77f86).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1257      +/-   ##
==========================================
- Coverage   99.99%   99.99%   -0.01%     
==========================================
  Files         858      858              
  Lines       18303    14727    -3576     
  Branches     1595     1589       -6     
==========================================
- Hits        18302    14726    -3576     
  Misses          1        1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gin-lsl
Copy link
Collaborator

gin-lsl commented Nov 28, 2024

组件列表页面的图标变得很小
image

@gin-lsl
Copy link
Collaborator

gin-lsl commented Nov 28, 2024

好像是我加载慢了？刚渲染时很小，然后会出现一个 Spinning，最后样式会变正常。

@yutingzhao1991
Copy link
Collaborator Author

好像是我加载慢了？刚渲染时很小，然后会出现一个 Spinning，最后样式会变正常。

嗯，有两个问题准备后面单独提 PR 修改：

  • antd web3 的样式 ssr 情况下没有挂载上，这个需要到时候在组件样式方案那里修复。
  • 文档加载会 loading 一下，这个要去掉，需要主题包修改。

不单独在这个 PR 里面处理了。

@yutingzhao1991 yutingzhao1991 merged commit 1c18695 into main Nov 28, 2024
14 checks passed
@yutingzhao1991 yutingzhao1991 deleted the feat/seo branch November 28, 2024 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thinkasany thinkasany thinkasany left review comments

@gin-lsl gin-lsl gin-lsl approved these changes

@LCJove LCJove Awaiting requested review from LCJove

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request] improve SEO for Ant Design Web3 website
3 participants
@yutingzhao1991 @gin-lsl @thinkasany