feat(Sender): tag slot add clear button #1295
Conversation
|
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello @IsDyh01, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new feature to add a clear button on 'tag' type slots in the Sender component. The implementation is well-structured, adding a removeTagSlot function to handle the removal logic and updating the rendering of tag slots to include the new button. The changes also include appropriate styling for the new element. My main feedback concerns a type safety issue where a MouseEvent is incorrectly cast to EventType. I've provided suggestions to fix this to ensure the component's API contract is respected.
| const removeTagSlot = (key: string, e?: EventType) => { | ||
| const span = getSlotDom(key); | ||
| if (span && editableRef.current && editableRef.current.contains(span)) { | ||
| editableRef.current.removeChild(span); | ||
| } | ||
| slotDomMap.current.delete(key); | ||
| // 移除配置与值 | ||
| slotConfigRef.current = (slotConfigRef.current || []).filter((item) => item.key !== key); | ||
| setSlotValues((prev) => { | ||
| const next = { ...prev }; | ||
| delete next[key]; | ||
| return next; | ||
| }); | ||
| setSlotPlaceholders((prev) => { | ||
| const next = new Map(prev); | ||
| next.delete(key); | ||
| return next; | ||
| }); | ||
| // 触发 onChange | ||
| const newValue = getEditorValue(); | ||
| onChange?.(newValue.value, e, newValue.config); | ||
| }; |
There was a problem hiding this comment.
The function currently accepts an e?: EventType argument, which is then passed to onChange. However, the click event that triggers this is a MouseEvent, which is not compatible with EventType (React.FormEvent<HTMLTextAreaElement> | React.ChangeEvent<HTMLTextAreaElement>). This creates a type inconsistency in the component's API. To resolve this, removeTagSlot should not accept an event argument, and onChange should be called with undefined for the event parameter.
const removeTagSlot = (key: string) => {
const span = getSlotDom(key);
if (span && editableRef.current && editableRef.current.contains(span)) {
editableRef.current.removeChild(span);
}
slotDomMap.current.delete(key);
// 移除配置与值
slotConfigRef.current = (slotConfigRef.current || []).filter((item) => item.key !== key);
setSlotValues((prev) => {
const next = { ...prev };
delete next[key];
return next;
});
setSlotPlaceholders((prev) => {
const next = new Map(prev);
next.delete(key);
return next;
});
// 触发 onChange
const newValue = getEditorValue();
onChange?.(newValue.value, undefined, newValue.config);
};
| onClick={(e) => { | ||
| removeTagSlot(node.key as string, e as unknown as EventType); | ||
| }} |
There was a problem hiding this comment.
The onClick handler is casting a MouseEvent to EventType, which is incorrect. Following the change suggested for removeTagSlot, this call should be updated to not pass the event argument.
| onClick={(e) => { | |
| removeTagSlot(node.key as string, e as unknown as EventType); | |
| }} | |
| onClick={() => { | |
| removeTagSlot(node.key as string); | |
| }} |
Bundle ReportChanges will increase total bundle size by 10.04kB (0.26%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: x-markdown-array-pushAssets Changed:
|
1 participant
中文版模板 / Chinese template
🤔 This is a ...
🔗 Related Issues
#1293
💡 Background and Solution
📝 Change Log