Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Waypoint splitting in PolarRoute goes one split depth too deep #83

Open
hjabbot opened this issue Oct 24, 2024 · 0 comments
Open

Waypoint splitting in PolarRoute goes one split depth too deep #83

hjabbot opened this issue Oct 24, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@hjabbot
Copy link
Collaborator

hjabbot commented Oct 24, 2024

The _split_loc method appears to be going too deep when trying to perform waypoint splitting in PolarRoute. The issue exists in environment_mesh.py hence the issue is being raised here.

The line if (cb_width < min_dcx) or (cb_height < min_dcy): should be changed to if (cb_width <= min_dcx) or (cb_height <= min_dcy): since the cb_width should equal min_dcx at max split depth.

I have done a quick test and can confirm that this prevents the waypoint splitting going too far. I have not done much more than that though, so some more rigorous testing should be done with this change in order. I have created a new branch with this change called split_loc_hotfix

@hjabbot hjabbot added the bug Something isn't working label Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant