From e4571cf56f5d3bf86f6605239c7d3ba0effe0bbb Mon Sep 17 00:00:00 2001 From: Samuel Hall <96304883+SamuelHall700@users.noreply.github.com> Date: Thu, 27 Apr 2023 09:56:28 +0100 Subject: [PATCH] minor tweeks to PR template --- .github/PULL_REQUEST_TEMPLATE/pull_request_template.md | 2 +- {.github/PULL_REQUEST_TEMPLATE => tests}/testing_strategy.md | 4 ---- 2 files changed, 1 insertion(+), 5 deletions(-) rename {.github/PULL_REQUEST_TEMPLATE => tests}/testing_strategy.md (99%) diff --git a/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md b/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md index 62126003..3983bcd0 100644 --- a/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md +++ b/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md @@ -32,6 +32,6 @@ This includes a collection of test files which should be run according to which - [ ] I have commented my code, particularly in hard-to-understand areas. - [ ] I have updated the documentation of the codebase where required. - [ ] My changes generate no new warnings. -- [ ] My PR has been made to the `intergration_testing` branch (**DO NOT SUBMIT A PR TO MAIN**) +- [ ] My PR has been made to the `0.2.x` branch (**DO NOT SUBMIT A PR TO MAIN**) diff --git a/.github/PULL_REQUEST_TEMPLATE/testing_strategy.md b/tests/testing_strategy.md similarity index 99% rename from .github/PULL_REQUEST_TEMPLATE/testing_strategy.md rename to tests/testing_strategy.md index dadc70b5..9f3825f8 100644 --- a/.github/PULL_REQUEST_TEMPLATE/testing_strategy.md +++ b/tests/testing_strategy.md @@ -6,7 +6,6 @@ Evidence that all the required regression tests have passed needs to be submitte Pull requests will not be accepted unless all required regression tests pass. ## Mesh Construction - | **Files altered** | **Tests** | |----------------------------|---------------------------------------| | `mesh_builder.py` | `tests/regression_tests/test_mesh.py` | @@ -21,7 +20,6 @@ Pull requests will not be accepted unless all required regression tests pass. | | | - ## Vessel Performance Modelling | **Files altered** | **Tests** | |-------------------------------------|-----------------------------------------| @@ -32,7 +30,6 @@ Pull requests will not be accepted unless all required regression tests pass. ## Route Planning - | **Files altered** | **Tests** | |----------------------|-----------------------------------------------------| | `crossing.py` | `tests/regression_tests/test_routes_dijkstra.py` | @@ -40,7 +37,6 @@ Pull requests will not be accepted unless all required regression tests pass. | | | - ## Testing files Some updates to PolarRoute may result in changes to meshes calculated in our tests suite (*such as adding additional attributes to the cellbox object*). These changes will cause the test suite to fail, though the mode of failure should be predictable.