-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: Allow for smaller screen sizes #55
Comments
agreed. ill look into it |
I have started to work on this. For now, I've removed the icon sidebar (icons at the top), reduced padding in a dozen places, and if there's just one single table in the screen, removed the "card" padding around it. Also, for DMARC reports lists, I've made some columns' display depend on the screen size. I will create some screenshots shortly to discuss. |
Please make a pull request at the end so we can merge the changes |
Will do. Is there a way to check out the app with some dummy data to experiment with, and does Symfony offer a local small builtin HTTP server to avoid having to set up Apache? Right now I'm doing the changes live on my production machine ... :-) |
Yes there is. But you’ll need the symfony cli and a working php installation. |
Great start. as for sample data. I’m currently not home so I can’t provide any at the moment |
Also. Maybe you can add the actions to a dropdown menu. Also for future sake. If any feature get added it’s already there. |
Was just typing ... :-) the top icons are for larger screens. As soon as the menu is there they will vanish. On mobile devices horizontal space is valuable, so I removed the sidebar menu. I could not get this to work properly (width adjustment, spacing, wrapping) anyway and there is ample space at the top. Updated screenshot coming soon. |
The langer screens have a sidebar for menu so they don’t need it. |
I don't fully like the button alignment and the table design yet, but that's the general idea. |
Don’t remove the sidebar menu and keep the title bar for just the title. |
I didn't remove it, I hid it because it wasn't working properly. I will try to show it e.g. for xl and xxl screens (width >1200px). |
I've implemented a version that keeps the current layout the same and hides non-primary columns on smaller devices. |
Why did you not wait for my pull request? |
Hi @jensb i wanted to try a few things myself but didn't mean to discourage you. |
OK. No worries. Trying to merge your changes now. |
Maybe just a quick finger exercise for someone who is experienced with bootstrap:
It would be wonderful if the layout were a bit more compact, so that nothing wraps in the left column and in the two wide columns of the dashboard each report fit in one line without wrapping.
The text was updated successfully, but these errors were encountered: