Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Allow for smaller screen sizes #55

Closed
wvogel opened this issue Mar 10, 2024 · 18 comments
Closed

Feature request: Allow for smaller screen sizes #55

wvogel opened this issue Mar 10, 2024 · 18 comments
Labels
enhancement New feature or request

Comments

@wvogel
Copy link
Contributor

wvogel commented Mar 10, 2024

Maybe just a quick finger exercise for someone who is experienced with bootstrap:
It would be wonderful if the layout were a bit more compact, so that nothing wraps in the left column and in the two wide columns of the dashboard each report fit in one line without wrapping.

@antedebaas antedebaas added the enhancement New feature or request label Mar 12, 2024
@antedebaas
Copy link
Owner

agreed. ill look into it

@jensb
Copy link

jensb commented Apr 26, 2024

I have started to work on this. For now, I've removed the icon sidebar (icons at the top), reduced padding in a dozen places, and if there's just one single table in the screen, removed the "card" padding around it. Also, for DMARC reports lists, I've made some columns' display depend on the screen size.

I will create some screenshots shortly to discuss.

@antedebaas
Copy link
Owner

Please make a pull request at the end so we can merge the changes

@jensb
Copy link

jensb commented Apr 26, 2024

Will do. Is there a way to check out the app with some dummy data to experiment with, and does Symfony offer a local small builtin HTTP server to avoid having to set up Apache? Right now I'm doing the changes live on my production machine ... :-)

@antedebaas
Copy link
Owner

Yes there is. But you’ll need the symfony cli and a working php installation.

https://symfony.com/doc/current/setup/symfony_server.html

@jensb
Copy link

jensb commented Apr 27, 2024

OK, that's great.
Can you quickly give me a SQL to insert 1-2 dummy TLS reports so I can also fine tune the TLS index display?

Here's a sneak preview. :-)
image

@antedebaas
Copy link
Owner

Great start.
I am however not a big fan of the buttons in the title bar. There is a menu for a reason.
Could you also add a bit more spacing. I know the current design uses a lot of space but I think the sweet spot is between the current design and this design.

as for sample data. I’m currently not home so I can’t provide any at the moment

@antedebaas
Copy link
Owner

Also. Maybe you can add the actions to a dropdown menu. Also for future sake. If any feature get added it’s already there.
If you click on the table row it could open te report and have a dropdown for all other actions.

@jensb
Copy link

jensb commented Apr 27, 2024

Was just typing ... :-) the top icons are for larger screens. As soon as the menu is there they will vanish. On mobile devices horizontal space is valuable, so I removed the sidebar menu. I could not get this to work properly (width adjustment, spacing, wrapping) anyway and there is ample space at the top.

Updated screenshot coming soon.

@antedebaas
Copy link
Owner

The langer screens have a sidebar for menu so they don’t need it.
I prefer not to have those buttons as I want a clean design.

@jensb
Copy link

jensb commented Apr 27, 2024

Yes, a clean design was also my goal. Also, most efficient screen usage. Thus I removed the sidebar menu :-)
It's probably a matter of taste. Let's see where we end up.

Mobile:
image

image

Medium (no menu, more columns):
image

Large and XL (even more columns, note the date formatting, Report IDs are shortened but fully available via tooltip)
image

@jensb
Copy link

jensb commented Apr 27, 2024

I don't fully like the button alignment and the table design yet, but that's the general idea.

@antedebaas
Copy link
Owner

Don’t remove the sidebar menu and keep the title bar for just the title.

@jensb
Copy link

jensb commented Apr 27, 2024

I didn't remove it, I hid it because it wasn't working properly.

I will try to show it e.g. for xl and xxl screens (width >1200px).
For anything less - especially mobile - a fixed sidebar column does not make sense IMHO.

@antedebaas
Copy link
Owner

I've implemented a version that keeps the current layout the same and hides non-primary columns on smaller devices.
any future changes can be made via a new issue/pr

@jensb
Copy link

jensb commented Apr 28, 2024

Why did you not wait for my pull request?
I spent quite some time today setting up a local dev environment for PHP just for this project (don't usually do PHP) and creating a pull request against master. Now I have to merge again.
That's a little discouraging regarding future collaboration. :-(

@antedebaas
Copy link
Owner

Hi @jensb i wanted to try a few things myself but didn't mean to discourage you.
youre still welcome to submit your pr.

@jensb
Copy link

jensb commented Apr 28, 2024

OK. No worries. Trying to merge your changes now.
We do disagree on a few things like which columns are "important" in a table but IMHO these are side issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants