Add Google Gemini llm. resolves #250 #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EdwinInAu
reviewed
Feb 13, 2025
| name: 'default_gemini_llm' | ||
| description: 'default gemini llm with spi' | ||
| model_name: 'gemini-2.0-flash' | ||
| max_tokens: 1048576 |
There was a problem hiding this comment.
The rest of the code looks good, but there’s a small issue with the value of the max_tokens parameter.
It means: "The maximum number of tokens that can be generated in the completion".
I suggest updating the value of max_tokens to either 1000 or 2000.
There was a problem hiding this comment.
sorry, I misunderstood max_tokens. I have corrected it.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
增加谷歌Gemini组件. resolves #250