Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"jsnext:main" in package.json isn't useful #407

Open
borisirota opened this issue Feb 15, 2016 · 3 comments
Open

"jsnext:main" in package.json isn't useful #407

borisirota opened this issue Feb 15, 2016 · 3 comments

Comments

@borisirota
Copy link

In order to make it useful I'll suggest:

  1. remove src from .npmignore (or leave it as is - see 2)
  2. babel src to es dir without the transform-es2015-modules-commonjs plugin so users of this library won't have to include all the plugins you use in your internal implementation and then set "jsnext:main": "es/index.js". check out redux as example
@astra137
Copy link

astra137 commented Mar 6, 2016

Seconded.

@troch
Copy link

troch commented Mar 6, 2016

Also .babelrc to be added to .npmignore

@anthonyshort
Copy link
Owner

Yeah that needs to be fixed up. If anyone wants to open a quick PR with these changes I'll get it merged

anthonyshort added a commit that referenced this issue Mar 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants