Skip to content

Commit aefe963

Browse files
vgrllucascosti
andauthored
Fix versioning for only notify requested members (github#24271)
Co-authored-by: Lucas Costi <[email protected]>
1 parent 9e9be2c commit aefe963

File tree

2 files changed

+18
-17
lines changed

2 files changed

+18
-17
lines changed

content/organizations/organizing-members-into-teams/managing-code-review-settings-for-your-team.md

Lines changed: 17 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -57,42 +57,43 @@ Any team members that have set their status to "Busy" will not be selected for r
5757
{% data reusables.user_settings.access_org %}
5858
{% data reusables.organizations.specific_team %}
5959
{% data reusables.organizations.team_settings %}
60-
5. In the left sidebar, click **Code review**
60+
1. In the left sidebar, click **Code review**
6161
![Code review button](/assets/images/help/teams/review-button.png)
62-
2. Select **Only notify requested team members.**
62+
1. Select **Only notify requested team members.**
6363
![Code review team notifications](/assets/images/help/teams/review-assignment-notifications.png)
64-
3. Click **Save changes**.
64+
1. Click **Save changes**.
6565
{% endif %}
6666

6767
## Configuring auto assignment
6868
{% data reusables.profile.access_org %}
6969
{% data reusables.user_settings.access_org %}
7070
{% data reusables.organizations.specific_team %}
7171
{% data reusables.organizations.team_settings %}
72-
5. In the left sidebar, click **Code review**
72+
1. In the left sidebar, click **Code review**
7373
![Code review button](/assets/images/help/teams/review-button.png)
74-
6. Select **Enable auto assignment**.
74+
1. Select **Enable auto assignment**.
7575
![Auto-assignment button](/assets/images/help/teams/review-assignment-enable.png)
76-
7. Under "How many team members should be assigned to review?", use the drop-down menu and choose a number of reviewers to be assigned to each pull request.
76+
1. Under "How many team members should be assigned to review?", use the drop-down menu and choose a number of reviewers to be assigned to each pull request.
7777
![Number of reviewers dropdown](/assets/images/help/teams/review-assignment-number.png)
78-
8. Under "Routing algorithm", use the drop-down menu and choose which algorithm you'd like to use. For more information, see "[Routing algorithms](#routing-algorithms)."
78+
1. Under "Routing algorithm", use the drop-down menu and choose which algorithm you'd like to use. For more information, see "[Routing algorithms](#routing-algorithms)."
7979
![Routing algorithm dropdown](/assets/images/help/teams/review-assignment-algorithm.png)
80-
9. Optionally, to always skip certain members of the team, select **Never assign certain team members**. Then, select one or more team members you'd like to always skip.
80+
1. Optionally, to always skip certain members of the team, select **Never assign certain team members**. Then, select one or more team members you'd like to always skip.
8181
![Never assign certain team members checkbox and dropdown](/assets/images/help/teams/review-assignment-skip-members.png)
82+
{% ifversion ghes < 3.4 %}
83+
1. Optionally, to only notify the team members chosen by code review assignment for each pull review request, under "Notifications" select **If assigning team members, don't notify the entire team.**
84+
{%- endif %}
8285
{% ifversion fpt or ghec or ghae-issue-5108 or ghes > 3.2 %}
83-
11. Optionally, to include members of child teams as potential reviewers when assigning requests, select **Child team members**.
84-
12. Optionally, to count any members whose review has already been requested against the total number of members to assign, select **Count existing requests**.
85-
13. Optionally, to remove the review request from the team when assigning team members, select **Team review request**.
86-
{%- else %}
87-
10. Optionally, to only notify the team members chosen by code review assignment for each pull review request, under "Notifications" select **If assigning team members, don't notify the entire team.**
86+
1. Optionally, to include members of child teams as potential reviewers when assigning requests, select **Child team members**.
87+
1. Optionally, to count any members whose review has already been requested against the total number of members to assign, select **Count existing requests**.
88+
1. Optionally, to remove the review request from the team when assigning team members, select **Team review request**.
8889
{%- endif %}
89-
14. Click **Save changes**.
90+
1. Click **Save changes**.
9091

9192
## Disabling auto assignment
9293
{% data reusables.profile.access_org %}
9394
{% data reusables.user_settings.access_org %}
9495
{% data reusables.organizations.specific_team %}
9596
{% data reusables.organizations.team_settings %}
96-
5. Select **Enable auto assignment** to remove the checkmark.
97+
1. Select **Enable auto assignment** to remove the checkmark.
9798
![Code review assignment button](/assets/images/help/teams/review-assignment-enable.png)
98-
6. Click **Save changes**.
99+
1. Click **Save changes**.

data/features/only-notify-requested-members.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,4 +4,4 @@ versions:
44
fpt: '*'
55
ghec: '*'
66
ghes: '>=3.4'
7-
ghae: '*'
7+
ghae: 'issue-5108'

0 commit comments

Comments
 (0)