Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set interface instead of concrete class in the container config #1

Open
kpicaza opened this issue Jun 20, 2020 · 0 comments
Open

Set interface instead of concrete class in the container config #1

kpicaza opened this issue Jun 20, 2020 · 0 comments
Assignees
@kpicaza
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@kpicaza
Copy link
Member

kpicaza commented Jun 20, 2020

Is your feature request related to a problem? Please describe.
In the current version, that factory configures a concrete Doctrine\DBAL\Connection class, to respect the Dependency Inversión Principle it would be better to configure the Doctrine\DBAL\Driver\Connection.

Describe the solution you'd like
Set Doctrine\DBAL\Driver\Connection as a service name in the config provider instead of current Doctrine\DBAL\Connection.
@kpicaza kpicaza added the question Further information is requested label Jun 20, 2020
@kpicaza kpicaza self-assigned this Jun 20, 2020
@kpicaza kpicaza added enhancement New feature or request good first issue Good for newcomers and removed question Further information is requested labels Jun 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kpicaza kpicaza

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kpicaza