Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(common): remove ZkvmIO #398

Open
zobront opened this issue Jul 24, 2024 · 0 comments
Open

fix(common): remove ZkvmIO #398

zobront opened this issue Jul 24, 2024 · 0 comments

Comments

@zobront
Copy link
Contributor

zobront commented Jul 24, 2024

Is your feature request related to a problem? Please describe.
To allow for compilation of kona-common in SP1, it is required to stop NativeIO from compiling. The current workaround is to implement a ZkvmIO alternative which is triggered when target_os = "zkvm", which contains only no-ops.

@clabby would like to make sure this workaround is removed, so adding this ticket to ensure that gets done.

Describe the solution you'd like
TBD

Describe alternatives you've considered
The obvious answer seems to be to use feature flags. I had a WIP version that used a default io feature flag, which could be turned off when importing into a zkvm environment. However, because kona is set up as a workspace, it was difficult to get the io feature to turn off across the board without adding a feature to many of the crates with lots of messy interdependencies.

Additional context
N/A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant