Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not compatible with Laravel 10 Mailer #33

Open
chrisGeonet opened this issue Jul 5, 2023 · 0 comments
Open

Not compatible with Laravel 10 Mailer #33

chrisGeonet opened this issue Jul 5, 2023 · 0 comments

Comments

@chrisGeonet
Copy link

In /laravel/framework/src/Illuminate/Mail/Mailer.php it uses the value() function with two arguments.

This corresponds with laravel/framework/src/Illuminate/Collections/helpers.php where it accepts two arguments.

In helpers.php in this package (which gets loaded first and overrides the Laravel version) it only accepts one argument.

There is a pull request to bring helpers.php up to date, but it has failed your tests as it's not compatible with php <=7.1. That shouldn't matter because Laravel is also not compatible with these versions of PHP.

Can the tests be updated and the pull request merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant