Skip to content

fix: 明细表自定义列头prefix重复展示异常 #3142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 3, 2025

Conversation

Alexzjt
Copy link
Contributor

@Alexzjt Alexzjt commented Apr 3, 2025

👀 PR includes

✨ Feature

  • New feature

🎨 Enhance

  • Code style optimization
  • Refactoring
  • Change the UI
  • Improve the performance
  • Type optimization

🐛 Bugfix

🔧 Chore

  • Test case
  • Docs / demos update
  • CI / workflow
  • Release version
  • Other ()

📝 Description

🖼️ Screenshot

Before After
image image

🔗 Related issue link

🔍 Self-Check before the merge

  • Add or update relevant docs.
  • Add or update relevant demos.
  • Add or update test case.
  • Add or update relevant TypeScript definitions.

@github-actions github-actions bot added the next 2.0-next 版本的问题 label Apr 3, 2025
@github-actions github-actions bot added the pr(fix) bug fix label Apr 3, 2025
Copy link
Contributor

github-actions bot commented Apr 3, 2025

你好 @Alexzjt,非常感谢你的贡献.
为了让代码更健壮, 请根据 贡献指南 补充相应单元测试 (文档改动或其他特殊场景除外), 如果有 API 改动, 请修改 相应的文档.
同时请检查 linttest 相关 CI 是否通过, 如果失败, 请点击 [Details] 按钮查看, 并根据日志修复.

Hello, @Alexzjt, Thanks for your contribution. In order to make the code more robust, please add the corresponding unit tests, and update the docs if there are API changes.
At the same time, please check whether the CI related to lint and test passes. If the CI fails, please click [Details] button to check and repair according to the log.

Copy link

Walkthrough

此PR修复了明细表中自定义列头prefix重复展示的问题。通过调整列头的采样逻辑,确保在存在重复prefix的情况下,列头能够正确展示。此外,添加了相关的测试用例以验证修复效果。

Changes

文件 概要
packages/s2-core/tests/data/custom-table-col-fields.ts 添加了用于测试的重复prefix列定义。
packages/s2-core/tests/spreadsheet/custom-table-col-spec.ts 增加了测试用例以验证重复prefix列头的高度计算是否正确。
packages/s2-core/src/facet/base-facet.ts 修改了列头采样逻辑,确保在存在重复prefix时能够正确处理。

@codecov-commenter
Copy link

codecov-commenter commented Apr 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.89%. Comparing base (ecdc9c8) to head (8ff04ac).
Report is 653 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #3142      +/-   ##
==========================================
+ Coverage   75.77%   79.89%   +4.12%     
==========================================
  Files         257      217      -40     
  Lines       11994    11891     -103     
  Branches     2464     2660     +196     
==========================================
+ Hits         9088     9500     +412     
+ Misses       1398      790     -608     
- Partials     1508     1601      +93     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

github-actions bot commented Apr 3, 2025

Size Change: +26 B (0%)

Total Size: 625 kB

Filename Size Change
./packages/s2-core/dist/s2.min.js 260 kB +26 B (+0.01%)
ℹ️ View Unchanged
Filename Size
./packages/s2-core/dist/s2-extends.min.js 156 kB
./packages/s2-core/dist/s2.min.css 581 B
./packages/s2-react-components/dist/s2-react-components.min.css 2.55 kB
./packages/s2-react-components/dist/s2-react-components.min.js 124 kB
./packages/s2-react/dist/s2-react.min.css 1.74 kB
./packages/s2-react/dist/s2-react.min.js 38.3 kB
./packages/s2-vue/dist/s2-vue.min.css 2.05 kB
./packages/s2-vue/dist/s2-vue.min.js 38.3 kB

compressed-size-action

@Alexzjt Alexzjt merged commit 986bdc2 into next Apr 3, 2025
9 checks passed
@Alexzjt Alexzjt deleted the fix/duplicatePrefix branch April 3, 2025 09:01
@lijinke666
Copy link
Member

🎉 This PR is included in version @antv/s2-v2.3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next 2.0-next 版本的问题 pr(fix) bug fix released on @latest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 明细表自定义表头传入后展示异常
3 participants