Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generalise app/services code #45

Open
martyn-w opened this issue Mar 3, 2018 · 0 comments
Open

Generalise app/services code #45

martyn-w opened this issue Mar 3, 2018 · 0 comments
Labels
enhancement

Comments

@martyn-w
Copy link
Collaborator

martyn-w commented Mar 3, 2018

All the code in app/services/*.rb seems to repeat itself (each service defines the same self.select_all_options and self.label methods) - these could be abstracted out into a common module and included into each service instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@martyn-w