Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DID test fixtures and regex escaping fixes #68

Merged
merged 11 commits into from
Nov 2, 2020
Merged

DID test fixtures and regex escaping fixes #68

merged 11 commits into from
Nov 2, 2020

Conversation

anweiss
Copy link
Owner

@anweiss anweiss commented Oct 28, 2020

Addresses #67.

@jonnycrunch FYI I'm adding a bunch of test fixtures based on w3c/did-extensions#138.

@anweiss anweiss self-assigned this Oct 28, 2020
@jonnycrunch
Copy link

nice! Thanks!

@anweiss
Copy link
Owner Author

anweiss commented Nov 2, 2020

@jonnycrunch I have added all of your proposed CDDL DID definitions as text fixtures to this crate and all of the known good documents are validating successfully. The known bad documents are also failing to validate as expected. I managed to squash a few parser and validation bugs thanks to your examples. So much appreciated!

Below is my list of findings:

  • capabilityDelegation.cddl has a typo on Line 3 ... should be capabilityDelegation and not capabilityDelgation
  • example2.json is missing a controller key (you mentioned you would remove this file anyways)
  • if service_example1.json is supposed to validate against service.cddl, it will fail because the root type is did-document not serviceEndpoint
  • typo in serviceEndpoint.cddl ... should be serviceEndpoint and not serivceEndpoint

@anweiss anweiss marked this pull request as ready for review November 2, 2020 17:05
@anweiss anweiss merged commit 6d4fb3e into master Nov 2, 2020
@anweiss anweiss deleted the did-testing branch November 2, 2020 17:17
@anweiss anweiss added this to the v1.0.0 milestone Nov 2, 2020
@jonnycrunch
Copy link

@anweiss Many thanks! I'm working on updating the examples.

@jonnycrunch
Copy link

regarding service.cddl , good catch! I owe you a beer! update pending.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants