Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we expose _action_cable_internal as a constant? #2

Open
ioquatix opened this issue Nov 16, 2024 · 2 comments
Open

Should we expose _action_cable_internal as a constant? #2

ioquatix opened this issue Nov 16, 2024 · 2 comments

Comments

@ioquatix
Copy link

ioquatix commented Nov 16, 2024

Even thought it's kind of an internal detail, it's actually part of the public interface of Redis integration.

conn.subscribe("_action_cable_internal") do |on|

e.g.

CHANNEL = "_action_cable_internal"
@ioquatix
Copy link
Author

To clarify a bit more, I think that my own implementation of the AsyncCableRedis adapter should use the same channel as it's going to be integrating with the same message bus.

@palkan
Copy link
Member

palkan commented Nov 25, 2024

Yeah, it's better to have it configurable, so you can run different apps attached to the same Redis without the overhead of processing the other app messages (even if you use channel_prefix you still invoke #broadcast in vain).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants