Expose server instance

[ioquatix]

ActionCable.server in Channel instances is a code smell. It makes testing more difficult than it should be (parallel tests might have more than one server).

I think Connection should expose server, e.g.

class TestChannel < ActionCable::Channel::Base
	def broadcast(data)
		# ActionCable.server.broadcast ... # bad!!!
		self.server.broadcast("testing-#{test_id}", data)
	end
	
	private def server
		@connection.send(:server)
	end

I don't think we should encourage users to write ActionCable.server except as a last resort.

[palkan]

Agree on that. I never liked it.

I'd even prefer to have just broadcast within the channel, not even server.broadcast, but we already have broadcast_to that has a slightly different logic (prepend stream names with the channel class name).

Given current design and compatibility with the previous version, probably, having connection.broadcast(...) is the way to go.