Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resubscribe() returns without exhausting all private subscribes #54

Closed
gadfly16 opened this issue Jun 5, 2024 · 1 comment
Closed

Comments

@gadfly16
Copy link

gadfly16 commented Jun 5, 2024

In case of private channels resubscribe() returns the subscribeToPrivate functions return value without checking its value, exiting the function and thus the for loop in case of a successfull subscription too. If both channels is subscribed for only one of them will resubscribe.

It should check the error value and only return if the err is not nil, like default:.

aopoltorzhicky added a commit that referenced this issue Jun 5, 2024
aopoltorzhicky added a commit that referenced this issue Jun 5, 2024
@aopoltorzhicky
Copy link
Owner

Thanks for the issue. It was fixed in #55.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants