Allow users to rename Zones #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BryceBeagle
changed the title
This was
linked to
issues
Sep 1, 2021
velovix
suggested changes
Sep 7, 2021
|
That's a reasonable suggestion. Would you have the name still double-clickable when not explicitly editing the Zone? |
|
I don't think that's necessary. Having to press the pencil to edit the zone makes sense to me. |
|
Bryce and I decided it was chill to just have a bit of text saying to double click the zone name to change it. Not quite ideal yet, but we'll get there in the future. |
velovix
approved these changes
Sep 8, 2021
|
Deleting a zone still causes a visual artifact: |
|
@velovix should we make the dark theme pencil icon consistent in this PR before merge, or in another PR? |
|
Issue with duplicated Alarm widgets should be resolved now |
|
@BryceBeagle Yeah I'll give it a little bit of a fix |
|
Okay, the "shine" of the pencil should now be transparent instead of white. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #194
Review along with #196 which resolves #195
TODO:
Zoneto "Screen"Feedback on whether this is intuitive enough would be appreciated