Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Dashboard can not search route from hosts name #2807

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ttgml
Copy link

@ttgml ttgml commented May 16, 2023

fix #2806 (comment)

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?

Fix the issue where host search does not work on the routing page.

Related issues

fix/resolve #2806

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@ttgml ttgml changed the title Update route.go fix: Dashboard can not search route from hosts name May 16, 2023
@codecov-commenter
Copy link

codecov-commenter commented May 16, 2023

Codecov Report

Merging #2807 (89d6718) into master (764a04e) will increase coverage by 2.27%.
The diff coverage is 0.00%.

❗ Current head 89d6718 differs from pull request most recent head cb15262. Consider uploading reports for the commit cb15262 to get more accurate results

@@            Coverage Diff             @@
##           master    #2807      +/-   ##
==========================================
+ Coverage   68.87%   71.15%   +2.27%     
==========================================
  Files         139      198      +59     
  Lines        3746     7765    +4019     
  Branches      880      876       -4     
==========================================
+ Hits         2580     5525    +2945     
- Misses       1166     1930     +764     
- Partials        0      310     +310     
Flag Coverage Δ
backend-e2e-test-ginkgo 65.09% <0.00%> (?)
backend-unit-test 49.92% <0.00%> (?)
frontend-e2e-test 70.13% <ø> (+1.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api/internal/handler/route/route.go 77.52% <0.00%> (ø)

... and 91 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@Baoyuantop Baoyuantop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E testing is required to verify this modification

@ttgml
Copy link
Author

ttgml commented May 17, 2023

E2E testing is required to verify this modification

Added

@ttgml ttgml requested a review from Baoyuantop July 8, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dashboard can not search route from hosts name
3 participants