From 088e5dbf4c1c124976cd8caf9ccaa15bd11ded0a Mon Sep 17 00:00:00 2001 From: Piotr Findeisen Date: Wed, 27 Nov 2024 19:04:42 +0100 Subject: [PATCH] Hide implicit optional dependency features in arrow-flight (#6806) A dependency X marked `optional = true` implicitly defines a feature X. Docs: https://doc.rust-lang.org/cargo/reference/features.html#optional-dependencies This can be seen at https://docs.rs/crate/arrow-flight/53.3.0/features The optional dependencies were not meant to be standalone features though. Using `dep:` in the `[features]` section is supposed to disable this. It is enough to use `dep:` once. It's used for every optional dependency for consistency. --- arrow-flight/Cargo.toml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arrow-flight/Cargo.toml b/arrow-flight/Cargo.toml index 702cb1360c2d..012d3947f02b 100644 --- a/arrow-flight/Cargo.toml +++ b/arrow-flight/Cargo.toml @@ -61,11 +61,11 @@ all-features = true [features] default = [] -flight-sql-experimental = ["arrow-arith", "arrow-data", "arrow-ord", "arrow-row", "arrow-select", "arrow-string", "once_cell"] +flight-sql-experimental = ["dep:arrow-arith", "dep:arrow-data", "dep:arrow-ord", "dep:arrow-row", "dep:arrow-select", "dep:arrow-string", "dep:once_cell"] tls = ["tonic/tls"] # Enable CLI tools -cli = ["anyhow", "arrow-array/chrono-tz", "arrow-cast/prettyprint", "clap", "tracing-log", "tracing-subscriber", "tonic/tls-webpki-roots"] +cli = ["dep:anyhow", "arrow-array/chrono-tz", "arrow-cast/prettyprint", "dep:clap", "dep:tracing-log", "dep:tracing-subscriber", "tonic/tls-webpki-roots"] [dev-dependencies] arrow-cast = { workspace = true, features = ["prettyprint"] }