diff --git a/.github/workflows/object_store.yml b/.github/workflows/object_store.yml index 1857b330326a..c960f093b018 100644 --- a/.github/workflows/object_store.yml +++ b/.github/workflows/object_store.yml @@ -141,6 +141,7 @@ jobs: echo "LOCALSTACK_CONTAINER=$(docker run -d -p 4566:4566 localstack/localstack:3.8.1)" >> $GITHUB_ENV echo "EC2_METADATA_CONTAINER=$(docker run -d -p 1338:1338 amazon/amazon-ec2-metadata-mock:v1.9.2 --imdsv2)" >> $GITHUB_ENV aws --endpoint-url=http://localhost:4566 s3 mb s3://test-bucket + aws --endpoint-url=http://localhost:4566 s3api create-bucket --bucket test-object-lock --object-lock-enabled-for-bucket aws --endpoint-url=http://localhost:4566 dynamodb create-table --table-name test-table --key-schema AttributeName=path,KeyType=HASH AttributeName=etag,KeyType=RANGE --attribute-definitions AttributeName=path,AttributeType=S AttributeName=etag,AttributeType=S --provisioned-throughput ReadCapacityUnits=5,WriteCapacityUnits=5 KMS_KEY=$(aws --endpoint-url=http://localhost:4566 kms create-key --description "test key") diff --git a/object_store/src/aws/mod.rs b/object_store/src/aws/mod.rs index 28df08b264fe..5ff3af58dcda 100644 --- a/object_store/src/aws/mod.rs +++ b/object_store/src/aws/mod.rs @@ -509,13 +509,11 @@ mod tests { } #[tokio::test] - #[ignore] async fn write_multipart_file_with_signature_object_lock() { maybe_skip_integration!(); - let bucket = "bg-object-lock-test"; + let bucket = "test-object-lock"; let store = AmazonS3Builder::from_env() - .with_region("eu-north-1") .with_bucket_name(bucket) .with_checksum_algorithm(Checksum::SHA256) .build() @@ -536,7 +534,9 @@ mod tests { part.await.unwrap(); let res = upload.complete().await.unwrap(); - println!("res={res:?}"); + assert!(res.e_tag.is_some(), "Should have valid etag"); + + store.delete(&path).await.unwrap(); } #[tokio::test]