From d06a572b4e90ce49a74071c7763360e4d6250fdc Mon Sep 17 00:00:00 2001 From: Andrew Lamb Date: Wed, 20 Dec 2023 15:32:15 -0500 Subject: [PATCH] Improve comments --- parquet/src/arrow/arrow_reader/mod.rs | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/parquet/src/arrow/arrow_reader/mod.rs b/parquet/src/arrow/arrow_reader/mod.rs index c81b3bb3bab4..52d7249a290e 100644 --- a/parquet/src/arrow/arrow_reader/mod.rs +++ b/parquet/src/arrow/arrow_reader/mod.rs @@ -677,13 +677,16 @@ pub(crate) fn apply_range( selection } -/// Evaluates an [`ArrowPredicate`], returning a [`RowSelection`] indiciating +/// Evaluates an [`ArrowPredicate`], returning a [`RowSelection`] indicating /// which rows to return. /// -/// If the [`ParquetRecordBatchReader`] also specified an explicit -/// [`RowSelection`] in addition to a predicate, `input_selection` will be -/// `Some`. In this case, the final [`RowSelection`] will be the conjunction of -/// this and the rows selected by `predicate` +/// `input_selection`: Optional pre-existing selection. If `Some`, then the +/// final [`RowSelection`] will be the conjunction of it and the rows selected +/// by `predicate`. +/// +/// Note: A pre-existing selection may come from evaluating a previous predicate +/// or if the [`ParquetRecordBatchReader`] specified an explicit +/// [`RowSelection`] in addition to one or more predicates. pub(crate) fn evaluate_predicate( batch_size: usize, array_reader: Box,