Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema Nullability Validation Fails to Account for Dictionary Nulls #4689

Closed
tustvold opened this issue Aug 11, 2023 · 2 comments · Fixed by #4691
Closed

Schema Nullability Validation Fails to Account for Dictionary Nulls #4689

tustvold opened this issue Aug 11, 2023 · 2 comments · Fixed by #4691
Assignees
Labels
arrow Changes to the arrow crate bug parquet Changes to the parquet crate

Comments

@tustvold
Copy link
Contributor

Describe the bug

Currently various constructs containing nested Field validate that the nullability of their children matches that of the schema. This helps to avoid subtle bugs that could result in data loss / corruption, see #4602 for more context on this.

Currently this is achieved by inspecting the null count of the child array, however, for dictionaries this is potentially incorrect as the null count of the parent only reflects the null count of the keys, and not the logical null count.

To Reproduce

Expected behavior

Additional context

@tustvold tustvold added the bug label Aug 11, 2023
@tustvold tustvold self-assigned this Aug 11, 2023
@tustvold tustvold added the parquet Changes to the parquet crate label Aug 15, 2023
@tustvold
Copy link
Contributor Author

label_issue.py automatically added labels {'parquet'} from #4691

@tustvold
Copy link
Contributor Author

label_issue.py automatically added labels {'arrow'} from #4691

@tustvold tustvold added the arrow Changes to the arrow crate label Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate bug parquet Changes to the parquet crate
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant