Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conditional Put Support #4879

Closed
tustvold opened this issue Sep 29, 2023 · 1 comment · Fixed by #4984
Closed

Conditional Put Support #4879

tustvold opened this issue Sep 29, 2023 · 1 comment · Fixed by #4984
Assignees
@tustvold
Labels
enhancement Any new improvement worthy of a entry in the changelog object-store Object Store Interface

Comments

@tustvold
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

All ObjectStores apart from S3 support conditional predicates on PUT. This is incredibly useful for building transactions on top of object storage.

Describe the solution you'd like

I would like to propose a new put_opts call, in a similar vein to the existing get_opts. This would take a PutOptions similar to GetOptions and containing these predicates.

Describe alternatives you've considered

Additional context

#4754 would likely also benefit from a put_opts call
@tustvold tustvold added the enhancement Any new improvement worthy of a entry in the changelog label Sep 29, 2023
@tustvold tustvold self-assigned this Sep 29, 2023
@tustvold tustvold added the object-store Object Store Interface label Sep 29, 2023
@tustvold tustvold mentioned this issue Sep 29, 2023
Closed
@tustvold tustvold mentioned this issue Oct 11, 2023
Merged
tustvold added a commit to tustvold/arrow-rs that referenced this issue Oct 11, 2023
@tustvold
Support ETag in InMemory (apache#4879)
4160e96
This was referenced Oct 11, 2023
Merged
Closed
tustvold added a commit that referenced this issue Oct 17, 2023
@tustvold
Generate ETags for InMemory and LocalFileSystem (#4879) (#4922)
ab87abd 
* Support ETag in InMemory (#4879)

* Add LocalFileSystem Etag

* Review feedback

* Review feedback
@tustvold
Copy link
Contributor Author

So it turns out that despite docs that would suggest it is supported, GCS doesn't support preconditions on write other than based on the version number. This is why we test 😅

@tustvold tustvold mentioned this issue Oct 23, 2023
Merged
tustvold added a commit to tustvold/arrow-rs that referenced this issue Oct 24, 2023
@tustvold
Conditional Put (apache#4879)
deb80bd
@tustvold tustvold mentioned this issue Oct 24, 2023
Merged
tustvold added a commit to tustvold/arrow-rs that referenced this issue Oct 24, 2023
@tustvold
Conditional Put (apache#4879)
f88574b
tustvold added a commit to tustvold/arrow-rs that referenced this issue Oct 25, 2023
@tustvold
Conditional Put (apache#4879)
c62a678
tustvold added a commit that referenced this issue Oct 27, 2023
@tustvold
Conditional Put (#4879) (#4984)
e3cce56 
* Add version to PutResult

* Conditional Put (#4879)

* Don't support HttpStore

* Add R2 Support

* Update Azure StatusCode

* Fixes

* Clippy

* Clippy

* PutRequestBuilder

* Clippy

* Add stress test

* Clippy
@tustvold tustvold mentioned this issue Mar 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tustvold tustvold

Labels
enhancement Any new improvement worthy of a entry in the changelog object-store Object Store Interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add ObjectStore::put_opts / Conditional Put (#4879) tustvold/arrow-rs
1 participant
@tustvold