Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a way to move fields out of parquet Row #5841

Closed
SHaaD94 opened this issue Jun 4, 2024 · 1 comment · Fixed by #5842
Closed

Add a way to move fields out of parquet Row #5841

SHaaD94 opened this issue Jun 4, 2024 · 1 comment · Fixed by #5842
Labels
enhancement Any new improvement worthy of a entry in the changelog parquet Changes to the parquet crate

Comments

@SHaaD94
Copy link
Contributor

SHaaD94 commented Jun 4, 2024

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
In our system, we read a lot of strings, stored in parquet. Until recently we've been using row.get_column_iter() and cloning all column values. It would be really nice if there would be a way move the ownership of column values out of the row.

Describe the solution you'd like
Move of internal fields structure out like this would work for us:

    pub fn into_columns(self) -> Vec<(String, Field)> {
        self.fields
    }

Describe alternatives you've considered
Currently, I just transmute the row into columns vector, but I don't really like keeping something as unsafe in my code base.

Additional context

@SHaaD94 SHaaD94 added the enhancement Any new improvement worthy of a entry in the changelog label Jun 4, 2024
@alamb alamb added the parquet Changes to the parquet crate label Jul 2, 2024
@alamb
Copy link
Contributor

alamb commented Jul 2, 2024

label_issue.py automatically added labels {'parquet'} from #5842

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any new improvement worthy of a entry in the changelog parquet Changes to the parquet crate
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants