-
Notifications
You must be signed in to change notification settings - Fork 1k
Change BooleanBuffer::append_packed_range to use apply_bitwise_binary_op
#8812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
BooleanBuffer::append_packed_range to use bitwise_binary_op
|
🤖 |
|
🤖: Benchmark completed Details
|
|
🤖 |
|
🤖: Benchmark completed Details
|
|
🤖 |
|
🤖: Benchmark completed Details
|
BooleanBuffer::append_packed_range to use bitwise_binary_opBooleanBuffer::append_packed_range to use apply_bitwise_binary_op
|
Thank you for the review @rluvaton -- the improvements to |
Dandandan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, I restarted the failing job
|
Thanks @Dandandan Looks like the integration test is also failing on main: |
|
Thanks @rluvaton and @Dandandan |
Which issue does this PR close?
Rationale for this change
We added an optimized packed implementation in the following PR:
apply_unary_opandapply_binary_opbitwise operations #8619Let's use it to make append_packed_range faster
What changes are included in this PR?
apply_bitwise_binary_opAre these changes tested?
Functionally by CI
I will also run benchmarks for this PR
Are there any user-facing changes?
Faster peformance