From 79c9b0aed023ada96d1b5507186fad9f6ba14942 Mon Sep 17 00:00:00 2001 From: Krisztian Szucs Date: Wed, 11 Dec 2024 18:44:28 +0100 Subject: [PATCH] minor cleanup --- cpp/src/arrow/compute/kernels/scalar_hash.cc | 6 ------ cpp/src/arrow/compute/light_array_internal.h | 16 ---------------- 2 files changed, 22 deletions(-) diff --git a/cpp/src/arrow/compute/kernels/scalar_hash.cc b/cpp/src/arrow/compute/kernels/scalar_hash.cc index dc4f16fa293b9..de1a8fb1ee19b 100644 --- a/cpp/src/arrow/compute/kernels/scalar_hash.cc +++ b/cpp/src/arrow/compute/kernels/scalar_hash.cc @@ -15,13 +15,7 @@ // specific language governing permissions and limitations // under the License. -/** - * @file scalar_hash.cc - * @brief Element-wise (scalar) kernels for hashing values. - */ - #include -//#include #include "arrow/array/array_base.h" #include "arrow/array/builder_primitive.h" diff --git a/cpp/src/arrow/compute/light_array_internal.h b/cpp/src/arrow/compute/light_array_internal.h index b61344fa362ca..5adb06e540009 100644 --- a/cpp/src/arrow/compute/light_array_internal.h +++ b/cpp/src/arrow/compute/light_array_internal.h @@ -34,10 +34,6 @@ namespace arrow { namespace compute { -// Forward declaration of KeyColumnArray for convenience of creating a type alias -class KeyColumnArray; -using KeyColumnVector = std::vector; - /// \brief Context needed by various execution engine operations /// /// In the execution engine this context is provided by either the node or the @@ -89,7 +85,6 @@ class ARROW_EXPORT KeyColumnArray { public: /// \brief Create an uninitialized KeyColumnArray KeyColumnArray() = default; - /// \brief Create a read-only view from buffers /// /// This is a view only and does not take ownership of the buffers. The lifetime @@ -226,17 +221,6 @@ class ARROW_EXPORT KeyColumnArray { ARROW_EXPORT Result ColumnMetadataFromDataType( const std::shared_ptr& type); -ARROW_EXPORT Result ColumnMetadataFromDataType(const DataType* type); - -/// \brief Create KeyColumnArray instances from an ArraySpan (nested types supported) -/// -/// The caller should ensure this is only called on "key" columns. Some nested types are -/// supported up to 1 level of nesting (e.g. List but not List>). -/// \see ColumnMetadataFromDataType for details -ARROW_EXPORT Result ColumnArrayFromArraySpan(const ArraySpan& array_span, - int64_t start_row, - int64_t num_rows); - /// \brief Create KeyColumnArray from ArrayData /// /// If `type` is a dictionary type then this will return the KeyColumnArray for