GH-38034: [Python] DataFrame Interchange Protocol - correct dtype information for categorical columns #38065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! Just one linter issue reported. |
|
Oh, bummer. Thanks for pinging me Dane! |
jorisvandenbossche
approved these changes
Oct 9, 2023
github-actions
bot
added
awaiting merge
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit db420c9. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 4 possible false positives for unstable benchmarks that are known to sometimes produce them. |
JerAguilon
pushed a commit
to JerAguilon/arrow
that referenced
this pull request
Oct 23, 2023
…pe information for categorical columns (apache#38065) ### Rationale for this change See: apache#38034 (comment) ### What changes are included in this PR? The `f_string` for the columns with categorical dtype is now corrected to reflect the type of the indices from the dictionary data type. Bit width has been correct before. From the spec: > For categoricals, the format string describes the type of the categorical in the data buffer. In case of a separate encoding of the categorical (e.g. an integer to string mapping), this can be derived from ``self.describe_categorical``. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * Closes: apache#38034 Authored-by: AlenkaF <[email protected]> Signed-off-by: AlenkaF <[email protected]>
loicalleyne
pushed a commit
to loicalleyne/arrow
that referenced
this pull request
Nov 13, 2023
…pe information for categorical columns (apache#38065) ### Rationale for this change See: apache#38034 (comment) ### What changes are included in this PR? The `f_string` for the columns with categorical dtype is now corrected to reflect the type of the indices from the dictionary data type. Bit width has been correct before. From the spec: > For categoricals, the format string describes the type of the categorical in the data buffer. In case of a separate encoding of the categorical (e.g. an integer to string mapping), this can be derived from ``self.describe_categorical``. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * Closes: apache#38034 Authored-by: AlenkaF <[email protected]> Signed-off-by: AlenkaF <[email protected]>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
…pe information for categorical columns (apache#38065) ### Rationale for this change See: apache#38034 (comment) ### What changes are included in this PR? The `f_string` for the columns with categorical dtype is now corrected to reflect the type of the indices from the dictionary data type. Bit width has been correct before. From the spec: > For categoricals, the format string describes the type of the categorical in the data buffer. In case of a separate encoding of the categorical (e.g. an integer to string mapping), this can be derived from ``self.describe_categorical``. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * Closes: apache#38034 Authored-by: AlenkaF <[email protected]> Signed-off-by: AlenkaF <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
See: #38034 (comment)
What changes are included in this PR?
The
f_stringfor the columns with categorical dtype is now corrected to reflect the type of the indices from the dictionary data type. Bit width has been correct before. From the spec:Are these changes tested?
Yes.
Are there any user-facing changes?
No.