-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[C++] Add filesystem stats #38465
Comments
Note: we have a T-Digest implementation for approximate quantiles, though https://github.com/HdrHistogram/HdrHistogram_c could be another efficient solution. |
Awesome, RocksDB also has a simple histogram for this(though it only does disk io) |
These things seem good to know. I think that at a high level the questions I want to know is if I'm operating efficiently. Sub-questions to this include:
|
FWIW in Lance what we've found most helpful in understanding filesystem / object store use is traces rather than metrics. We use the Rust I think in Arrow C++, you could integrate OpenTelemetry tracing in the filesystems. @amoeba did some similar work integrating it with Flight C++. That being said, collecting these kinds of metrics would be useful for additional information in benchmark comparisons. It would be nice, for example, for a benchmark to show that a certain optimization reduced that number of IO requests. |
Describe the enhancement requested
It would be nice to have per-filesystem stats to better analyze how filesystems are used by libraries (such as the Parquet reader).
Potentially useful stats:
(perhaps some of those would be too costly to record, we'll see)
Component(s)
C++
The text was updated successfully, but these errors were encountered: