Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-38964: [C++] Fix spelling (compute) #38965

Merged
merged 36 commits into from
Jan 4, 2024
Merged

GH-38964: [C++] Fix spelling (compute) #38965

merged 36 commits into from
Jan 4, 2024

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Nov 29, 2023 •
edited by github-actions bot
Loading

Rationale for this change

What changes are included in this PR?

Spelling fixes to cpp/src/arrow/compute/

Are these changes tested?

Are there any user-facing changes?

jsoref added 30 commits November 28, 2023 20:37
@jsoref
spelling: across
d45d184 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: against
04f3d61 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: aggregates
093fb6c 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: array
e710278 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: beginning
333ecb5 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: bool
04a8a64 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: continuous
556acc0 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: convenience
aebadbf 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: encoding
46f81af 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: extension
326a5cb 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: generated
7d38904 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: initialize
83fee99 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: interpolation
abfa92e 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: iterator
af2dcb3 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: multiplier
1a3c52a 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: nanoseconds
90867d7 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: nonexistent
72af25a 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: nullable
26d8f5f 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: occurrences
8ccb309 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: offset
9504094 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: omitted
9eaf007 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: one
c0f9555 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: options
426981b 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: override
9c4c44c 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: parameterizing
f1e3aee 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: precision
8c2e7f0 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: preexisting
7ac5ede 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: previously
dba9c62 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: quantile
fe00848 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: segment
e201aeb 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: segmented
7b36186 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: selector
6093a3f 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: specifying
ab857e9 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: targeting
c2e31a9 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: type
ee419f2 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: values
c7cd2fb 
Signed-off-by: Josh Soref <[email protected]>
@github-actions GitHub Actions
Copy link

⚠️ GitHub issue #38964 has been automatically assigned in GitHub to PR creator.

mapleFU
mapleFU approved these changes Jan 4, 2024
View reviewed changes
Copy link
Member

@mapleFU mapleFU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @felipecrv

@github-actions github-actions bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Jan 4, 2024
felipecrv
felipecrv approved these changes Jan 4, 2024
View reviewed changes
cpp/src/arrow/compute/kernels/vector_run_end_encode.cc
: run_end_type{std::move(run_end_type)} {}

~RunEndEncondingState() override = default;
~RunEndEncodingState() override = default;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wrote this 🤡

@felipecrv felipecrv merged commit ccc674c into apache:main Jan 4, 2024
32 of 36 checks passed
@felipecrv felipecrv removed the awaiting committer review Awaiting committer review label Jan 4, 2024
@jsoref jsoref deleted the spelling-compute branch January 4, 2024 18:27
@conbench-apache-arrow conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit ccc674c.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.

clayburn pushed a commit to clayburn/arrow that referenced this pull request Jan 23, 2024
@jsoref @clayburn
apacheGH-38964: [C++] Fix spelling (compute) (apache#38965)
cb4a036 
### Rationale for this change

### What changes are included in this PR?

Spelling fixes to cpp/src/arrow/compute/

### Are these changes tested?

### Are there any user-facing changes?

* Closes: apache#38964

Authored-by: Josh Soref <[email protected]>
Signed-off-by: Felipe Oliveira Carvalho <[email protected]>
dgreiss pushed a commit to dgreiss/arrow that referenced this pull request Feb 19, 2024
@jsoref @dgreiss
apacheGH-38964: [C++] Fix spelling (compute) (apache#38965)
5abb87e 
### Rationale for this change

### What changes are included in this PR?

Spelling fixes to cpp/src/arrow/compute/

### Are these changes tested?

### Are there any user-facing changes?

* Closes: apache#38964

Authored-by: Josh Soref <[email protected]>
Signed-off-by: Felipe Oliveira Carvalho <[email protected]>
zanmato1984 pushed a commit to zanmato1984/arrow that referenced this pull request Feb 28, 2024
@jsoref @zanmato1984
apacheGH-38964: [C++] Fix spelling (compute) (apache#38965)
1b51241 
### Rationale for this change

### What changes are included in this PR?

Spelling fixes to cpp/src/arrow/compute/

### Are these changes tested?

### Are there any user-facing changes?

* Closes: apache#38964

Authored-by: Josh Soref <[email protected]>
Signed-off-by: Felipe Oliveira Carvalho <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mapleFU mapleFU mapleFU approved these changes

@felipecrv felipecrv felipecrv approved these changes

Assignees
No one assigned
Labels
Component: C++
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[C++][Compute] Spelling errors identified by check-spelling
3 participants
@jsoref @felipecrv @mapleFU