You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Due to class protection levels it is not currently possible to implement a flight server outside of AspNet.Core.
i.e. to start a flight server as a non-Kestrel GRPC server the following code can't be used due to protection level of the protocol and FlightServerImplementation classes.
using Apache.Arrow.Flight.Protocol;
using Apache.Arrow.Flight.Server.Internal;
var flightServer = new FlightServerImpl();
var server = new Server
{
Services = { FlightService.BindService(new FlightServerImplementation(flightServer)) },
Ports = { new ServerPort("0.0.0.0", 5001, ServerCredentials.Insecure) } }
};
server.Start();
Component(s)
C#, FlightRPC
The text was updated successfully, but these errors were encountered:
….net versions (#41348)
### Rationale for this change
With the existing structure it is not possible to create a flight RPC service as a regular GRPC service, outside of AspNet.Core/Kestrel.
This can be supported by changing the protection level of the generated classes and FlightServiceImplementation.cs
### What changes are included in this PR?
Change protection level from internal to public for generated protocol files and FlightServiceImplementation.cs
### Are these changes tested?
Confirmed that classes are public in the built assembly.
### Are there any user-facing changes?
Generated protocol classes will become visible to end users.
* GitHub Issue: #41347
Authored-by: David Chapman <[email protected]>
Signed-off-by: Curt Hagenlocher <[email protected]>
@qed-, I should probably have looked at the build output more closely. Do you actually need .NET 4.6.2 support or is .NET 4.7.2 okay? The reason I ask is that there's at least one dependency here which requires netstandard2.0, and the situation with net462 and netstandard2.0 is a bit messy to say the least. If you don't specifically need 462 then targeting 472 probably makes more sense.
Describe the enhancement requested
Due to class protection levels it is not currently possible to implement a flight server outside of AspNet.Core.
i.e. to start a flight server as a non-Kestrel GRPC server the following code can't be used due to protection level of the protocol and FlightServerImplementation classes.
Component(s)
C#, FlightRPC
The text was updated successfully, but these errors were encountered: