Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R][CI]: Remove more defunct rhub containers #41841

Closed
jonkeane opened this issue May 27, 2024 · 1 comment
Closed

[R][CI]: Remove more defunct rhub containers #41841

jonkeane opened this issue May 27, 2024 · 1 comment
Assignees
@jonkeane
Labels
Component: Continuous Integration Component: R Type: enhancement
Milestone
17.0.0

Comments

@jonkeane
Copy link
Member

Describe the enhancement requested

In debugging a CRAN submission, found another location where we are using the stale rhub containers.

Component(s)

Continuous Integration, R
@github-actions github-actions bot mentioned this issue May 27, 2024
Merged
@jonkeane
Copy link
Member Author

Issue resolved by pull request 41828
#41828

@jonkeane jonkeane added this to the 17.0.0 milestone May 28, 2024
jonkeane added a commit that referenced this issue May 28, 2024
@jonkeane
GH-41841: [R][CI] Remove more defunct rhub containers (#41828)
8f3bf67 
Testing CI to see if we can replicate the incoming NOTEs:

```
Found the following (possibly) invalid file URIs:
  URI: articles/read_write.html
    From: README.md
  URI: articles/data_wrangling.html
    From: README.md
  URI: reference/acero.html
    From: README.md
  URI: articles/install.html
    From: README.md
  URI: articles/install_nightly.html
    From: README.md
```

I wasn't able to replicate them in CI (even with `_R_CHECK_CRAN_INCOMING_REMOTE_` set to true, and installing pandoc so that the docs could be munged.)

But in the process realized we were running old rhub images that aren't updated anymore (thanks, @ thisisnic). Also did a bit of cleanup of `--run-donttest` which is now no longer needed (was removed in favor of the env var in 4.0)
* GitHub Issue: #41841

Authored-by: Jonathan Keane <[email protected]>
Signed-off-by: Jonathan Keane <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonkeane jonkeane

Labels
Component: Continuous Integration Component: R Type: enhancement
Projects
None yet
Milestone
17.0.0
Development

No branches or pull requests
1 participant
@jonkeane