GH-42030: [Java] Update Unit Tests for Adapter Module #42038

llama90 · 2024-06-08T16:25:54Z

Rationale for this change

Update package from JUnit 4(org.junit) to JUnit 5(org.junit.jupiter).

What changes are included in this PR?

avro and jdbc module
- Replacing org.junit with org.junit.jupiter.api.
- Updating Assertions.assertXXX to assertXXX using static imports.
- Updating annotations such as @Before, @After.
  - @Before -> @BeforeEach
  - @After -> @AfterEach
  - @Test -> @Test with org.junit.jupiter
  - @ClassRule -> @TempDir and @BeforeAll
- Updating Parameterized test
- Doing self review for avro
- Dealing with java.io.IOException: Failed to delete temp directory on Windows with JDK 11
- Exploring a more effective structure for ParameterizedTest in JDBC tests.
- Doing self review for jdbc
orc module
- Reviewing the build method
- Updating annotations such as @BeforeAll, @Rule, @TemporaryFolder
- Doing self review

Are these changes tested?

Yes, existing tests have passed.

Are there any user-facing changes?

No.

GitHub Issue: [Java] Update Unit Tests for Adapter Module #42030

github-actions · 2024-06-08T16:26:18Z

⚠️ GitHub issue #42030 has been automatically assigned in GitHub to PR creator.

llama90 · 2024-06-08T16:30:04Z

I currently use explicit calls to initializeDatabase in each test method. However, I believe there is a more efficient structure for this process.

Reason

In JUnit 4, the method calling sequence is: constructor -> @Before -> @ParameterizedTest.
- In JUnit 5, the constructor is not used for @ParameterizedTest.

llama90 · 2024-06-08T16:35:41Z

java/adapter/jdbc/src/test/java/org/apache/arrow/adapter/jdbc/AbstractJdbcToArrowTest.java

  /**
   * This method creates Connection object and DB table and also populate data into table for test.
   *
   * @throws SQLException on error
   * @throws ClassNotFoundException on error
   */
-  @Before
-  public void setUp() throws SQLException, ClassNotFoundException {
+  protected void initializeDatabase(Table table) throws SQLException, ClassNotFoundException {


@vibhatha I'll look into it more, but if you have any suggestions for a better structure, I would really appreciate your advice.

cc @lidavidm

classDiagram direction LR class AbstractJdbcToArrowTest { } class JdbcToArrowCharSetTest { } class JdbcToArrowDataTypesTest { } class JdbcToArrowMapDataTypeTest { } class JdbcToArrowNullTest { } class JdbcToArrowOptionalColumnsTest { } class JdbcToArrowTest { } class JdbcToArrowTimeZoneTest { } class JdbcToArrowVectorIteratorTest { } AbstractJdbcToArrowTest <|-- JdbcToArrowCharSetTest AbstractJdbcToArrowTest <|-- JdbcToArrowDataTypesTest AbstractJdbcToArrowTest <|-- JdbcToArrowMapDataTypeTest AbstractJdbcToArrowTest <|-- JdbcToArrowNullTest AbstractJdbcToArrowTest <|-- JdbcToArrowOptionalColumnsTest AbstractJdbcToArrowTest <|-- JdbcToArrowTest AbstractJdbcToArrowTest <|-- JdbcToArrowTimeZoneTest JdbcToArrowTest <|-- JdbcToArrowVectorIteratorTest

Loading

@llama90 I will review this tomorrow. Thanks.

I guess what you are concerned about is making the database connection for each test case with @BeforeEach setup method?

Yes, we need to create a database connection with a different .yml for each test, but @BeforeEach cannot take arguments for @ParameterizedTest.

I described something similar here.

I think this is fine

llama90 · 2024-06-09T15:08:15Z

Ummm....

There is a JUnit 5 bug on Windows (Server 2022) with JDK 11, specifically in the CI used by Arrow.

Should we consider a rollback because of this, or is there another solution we could explore?

error message

Error:  Tests run: 5, Failures: 0, Errors: 4, Skipped: 0, Time elapsed: 3.553 s <<< FAILURE! -- in org.apache.arrow.adapter.avro.AvroToArrowIteratorTest
[INFO] --- maven-surefire-plugin:3.2.5:test (default-test) @ arrow-jdbc ---
Error:  org.apache.arrow.adapter.avro.AvroToArrowIteratorTest.testArrayType -- Time elapsed: 0.125 s <<< ERROR!
java.io.IOException: Failed to delete temp directory D:\a\arrow\arrow\java\adapter\avro\target\junit4444716940079148427. The following paths could not be deleted (see suppressed exceptions for details): <root>, test.avro
	at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1541)
	at java.base/java.util.stream.SortedOps$RefSortingSink.end(SortedOps.java:395)
	at java.base/java.util.stream.Sink$ChainedReference.end(Sink.java:258)
	at java.base/java.util.stream.Sink$ChainedReference.end(Sink.java:258)
	at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:485)
	at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:474)
	at java.base/java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:150)
	at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:173)
	at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
	at java.base/java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:497)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1541)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1541)
	Suppressed: java.nio.file.DirectoryNotEmptyException: D:\a\arrow\arrow\java\adapter\avro\target\junit4444716940079148427
		at java.base/sun.nio.fs.WindowsFileSystemProvider.implDelete(WindowsFileSystemProvider.java:271)
		at java.base/sun.nio.fs.AbstractFileSystemProvider.delete(AbstractFileSystemProvider.java:105)
		at java.base/java.nio.file.Files.delete(Files.java:1142)
		at java.base/java.nio.file.Files.walkFileTree(Files.java:2743)
		at java.base/java.nio.file.Files.walkFileTree(Files.java:2797)
		... 13 more
	Suppressed: java.nio.file.FileSystemException: D:\a\arrow\arrow\java\adapter\avro\target\junit4444716940079148427\test.avro: The process cannot access the file because it is being used by another process.

		at java.base/sun.nio.fs.WindowsException.translateToIOException(WindowsException.java:92)
		at java.base/sun.nio.fs.WindowsException.rethrowAsIOException(WindowsException.java:103)
		at java.base/sun.nio.fs.WindowsException.rethrowAsIOException(WindowsException.java:108)
		at java.base/sun.nio.fs.WindowsFileSystemProvider.implDelete(WindowsFileSystemProvider.java:274)
		at java.base/sun.nio.fs.AbstractFileSystemProvider.delete(AbstractFileSystemProvider.java:105)
		at java.base/java.nio.file.Files.delete(Files.java:1142)
		at java.base/java.nio.file.Files.walkFileTree(Files.java:2725)
		at java.base/java.nio.file.Files.walkFileTree(Files.java:2797)
		... 13 more
		Suppressed: java.nio.file.FileSystemException: D:\a\arrow\arrow\java\adapter\avro\target\junit4444716940079148427\test.avro: The process cannot access the file because it is being used by another process.

			... 21 more

UPDATE:

I tried two kinds of approaches

Using `try-with-resources` Statements for `FileOutputStream` and `FileInputStream`

try (FileOutputStream outStream = new FileOutputStream(dataFile);
     FileInputStream inStream = new FileInputStream(dataFile)) {
    BinaryEncoder encoder = new EncoderFactory().directBinaryEncoder(outStream, null);
    DatumWriter<Object> writer = new GenericDatumWriter<>(schema);
    for (Object value : data) {
        writer.write(value, encoder);
    }
    outStream.flush();

    BinaryDecoder decoder = new DecoderFactory().directBinaryDecoder(inStream, null);
    return AvroToArrow.avroToArrow(schema, decoder, config);
}

Separating `FileOutputStream` and `FileInputStream` Usage to Avoid Concurrent Access

  protected VectorSchemaRoot writeAndRead(Schema schema, List data) throws Exception {
    File dataFile = new File(TMP, "test.avro");

    try (FileOutputStream out = new FileOutputStream(dataFile)) {
      BinaryEncoder encoder = new EncoderFactory().directBinaryEncoder(out, null);
      DatumWriter<Object> writer = new GenericDatumWriter<>(schema);
      for (Object value : data) {
        writer.write(value, encoder);
      }
      out.flush();
    }

    try (FileInputStream in = new FileInputStream(dataFile)) {
      BinaryDecoder decoder = new DecoderFactory().directBinaryDecoder(in, null);
      return AvroToArrow.avroToArrow(schema, decoder, config);
    }
  }

vibhatha · 2024-06-09T23:28:10Z

Ummm....

There is a JUnit 5 bug on Windows (Server 2022) with JDK 11, specifically in the CI used by Arrow.

* [@TempDir directory cannot be deleted on Windows with Java 11 junit-team/junit5#2811](https://github.com/junit-team/junit5/issues/2811)

* https://github.com/apache/arrow/actions/runs/9437309980/job/25993017637?pr=42038#step:5:2647

Should we consider a rollback because of this, or is there another solution we could explore?
error message

Error:  Tests run: 5, Failures: 0, Errors: 4, Skipped: 0, Time elapsed: 3.553 s <<< FAILURE! -- in org.apache.arrow.adapter.avro.AvroToArrowIteratorTest
[INFO] --- maven-surefire-plugin:3.2.5:test (default-test) @ arrow-jdbc ---
Error:  org.apache.arrow.adapter.avro.AvroToArrowIteratorTest.testArrayType -- Time elapsed: 0.125 s <<< ERROR!
java.io.IOException: Failed to delete temp directory D:\a\arrow\arrow\java\adapter\avro\target\junit4444716940079148427. The following paths could not be deleted (see suppressed exceptions for details): <root>, test.avro
	at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1541)
	at java.base/java.util.stream.SortedOps$RefSortingSink.end(SortedOps.java:395)
	at java.base/java.util.stream.Sink$ChainedReference.end(Sink.java:258)
	at java.base/java.util.stream.Sink$ChainedReference.end(Sink.java:258)
	at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:485)
	at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:474)
	at java.base/java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:150)
	at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:173)
	at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
	at java.base/java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:497)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1541)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1541)
	Suppressed: java.nio.file.DirectoryNotEmptyException: D:\a\arrow\arrow\java\adapter\avro\target\junit4444716940079148427
		at java.base/sun.nio.fs.WindowsFileSystemProvider.implDelete(WindowsFileSystemProvider.java:271)
		at java.base/sun.nio.fs.AbstractFileSystemProvider.delete(AbstractFileSystemProvider.java:105)
		at java.base/java.nio.file.Files.delete(Files.java:1142)
		at java.base/java.nio.file.Files.walkFileTree(Files.java:2743)
		at java.base/java.nio.file.Files.walkFileTree(Files.java:2797)
		... 13 more
	Suppressed: java.nio.file.FileSystemException: D:\a\arrow\arrow\java\adapter\avro\target\junit4444716940079148427\test.avro: The process cannot access the file because it is being used by another process.

		at java.base/sun.nio.fs.WindowsException.translateToIOException(WindowsException.java:92)
		at java.base/sun.nio.fs.WindowsException.rethrowAsIOException(WindowsException.java:103)
		at java.base/sun.nio.fs.WindowsException.rethrowAsIOException(WindowsException.java:108)
		at java.base/sun.nio.fs.WindowsFileSystemProvider.implDelete(WindowsFileSystemProvider.java:274)
		at java.base/sun.nio.fs.AbstractFileSystemProvider.delete(AbstractFileSystemProvider.java:105)
		at java.base/java.nio.file.Files.delete(Files.java:1142)
		at java.base/java.nio.file.Files.walkFileTree(Files.java:2725)
		at java.base/java.nio.file.Files.walkFileTree(Files.java:2797)
		... 13 more
		Suppressed: java.nio.file.FileSystemException: D:\a\arrow\arrow\java\adapter\avro\target\junit4444716940079148427\test.avro: The process cannot access the file because it is being used by another process.

			... 21 more

UPDATE:

I tried two kinds of approaches

Using `try-with-resources` Statements for `FileOutputStream` and `FileInputStream`

try (FileOutputStream outStream = new FileOutputStream(dataFile);
     FileInputStream inStream = new FileInputStream(dataFile)) {
    BinaryEncoder encoder = new EncoderFactory().directBinaryEncoder(outStream, null);
    DatumWriter<Object> writer = new GenericDatumWriter<>(schema);
    for (Object value : data) {
        writer.write(value, encoder);
    }
    outStream.flush();

    BinaryDecoder decoder = new DecoderFactory().directBinaryDecoder(inStream, null);
    return AvroToArrow.avroToArrow(schema, decoder, config);
}

Separating `FileOutputStream` and `FileInputStream` Usage to Avoid Concurrent Access

  protected VectorSchemaRoot writeAndRead(Schema schema, List data) throws Exception {
    File dataFile = new File(TMP, "test.avro");

    try (FileOutputStream out = new FileOutputStream(dataFile)) {
      BinaryEncoder encoder = new EncoderFactory().directBinaryEncoder(out, null);
      DatumWriter<Object> writer = new GenericDatumWriter<>(schema);
      for (Object value : data) {
        writer.write(value, encoder);
      }
      out.flush();
    }

    try (FileInputStream in = new FileInputStream(dataFile)) {
      BinaryDecoder decoder = new DecoderFactory().directBinaryDecoder(in, null);
      return AvroToArrow.avroToArrow(schema, decoder, config);
    }
  }

@llama90 thanks for taking a very thorough assessment on this. I think the issue still persists. Furthermore looking into the JUNIT5 bug report, it seems that there isn't a solid fix yet. So my suggestion would be to fix it once that's resolved.

Although, we can create two sub-issues for this ticket, one for functional conversion (orc) and other for non-functional bits.
So that we can track the failing one later. But I have doubts about that approach.

cc @lidavidm Appreciate your feedback.

vibhatha · 2024-06-09T23:30:39Z

java/adapter/avro/src/test/java/org/apache/arrow/adapter/avro/AvroTestBase.java

-  @ClassRule
-  public static final TemporaryFolder TMP = new TemporaryFolder();
+  @TempDir
+  public File TMP;


Any specific reason for this change?

The new JUnit API is different.

I understand that in JUnit 5, the alternative for temporary directories is to use @TempDir. So I modified it accordingly.

Annotation Interface TempDir

@TempDir can be used to annotate a field in a test class or a parameter in a lifecycle method or test method of type Path or File that should be resolved into a temporary directory.

Oh, that seems to be related, though can we re-check by running CIs?

java/adapter/jdbc/src/test/java/org/apache/arrow/adapter/jdbc/h2/JdbcToArrowCharSetTest.java

lidavidm

It seems a merge might have gone wrong? There are changes from other PRs

lidavidm · 2024-06-10T00:45:31Z

java/adapter/avro/src/test/java/org/apache/arrow/adapter/avro/AvroTestBase.java

-  @ClassRule
-  public static final TemporaryFolder TMP = new TemporaryFolder();
+  @TempDir
+  public File TMP;


The new JUnit API is different.

lidavidm · 2024-06-12T05:53:31Z

java/adapter/jdbc/src/test/java/org/apache/arrow/adapter/jdbc/AbstractJdbcToArrowTest.java

  /**
   * This method creates Connection object and DB table and also populate data into table for test.
   *
   * @throws SQLException on error
   * @throws ClassNotFoundException on error
   */
-  @Before
-  public void setUp() throws SQLException, ClassNotFoundException {
+  protected void initializeDatabase(Table table) throws SQLException, ClassNotFoundException {


I think this is fine

lidavidm · 2024-06-12T06:00:55Z

java/bom/pom.xml

+            <licenseHeader>
+              <file>${maven.multiModuleProjectDirectory}/dev/license/asf-xml.license</file>
+              <delimiter>(&lt;configuration|&lt;project)</delimiter>
+            </licenseHeader>


Where did this come from?

Oh, maybe this is a merge artifact...it seems to already be on main?

I did a rebase and saw that changes from another PR were left out.

What do you think about issues with @TempDir when using JDK 11 on Windows?

GH-42030: [Java] Update Unit Tests for Adapter Module #42038 (comment)

If possible, can I fix the problem with a new PR?

@lidavidm we seems to have a problem here with Windows: https://github.com/apache/arrow/actions/runs/9490384583/job/26153755020?pr=42038#step:5:10625

I think we need to fix it here.

Could this be helpful?

junit-team/junit5#3236
junit-team/junit5#3249

…or avro

- initize database within the test methods

vibhatha · 2024-06-13T11:20:47Z

@llama90 the CI failures are due to spotless issue. Could you please try mvn spotless:apply before building?
We will integrate pre-commit sooner, so that this won't be an issue.

llama90 · 2024-06-13T11:27:57Z

@llama90 the CI failures are due to spotless issue. Could you please try mvn spotless:apply before building? We will integrate pre-commit sooner, so that this won't be an issue.

Yes, I tried to check (mvn spotless:apply) before PR, but sometimes I missed it 🥲

I can't test the environment for Windows locally, I am repeatedly testing it through CI.

vibhatha · 2024-06-13T13:53:19Z

Yes, I tried to check (mvn spotless:apply) before PR, but sometimes I missed it 🥲

Yeah that happens, and after pre-commit that will be warned before committing.

I can't test the environment for Windows locally, I am repeatedly testing it through CI.

I understand. Thanks.

llama90 · 2024-06-13T15:07:44Z

java/adapter/avro/src/test/java/org/apache/arrow/adapter/avro/AvroToArrowIteratorTest.java

I was getting an error in Windows saying "failed to delete temp directory" because "The process cannot access the file because it is being used by another process."

Error Link

To fix this, I found out that using try-with-resources to properly close resources would help.

But for the convert method, the FileInputStream (fis) needs to stay open for the iterator after the convert method is called. This caused the error because the fis wasn't properly closed. So, I made a writeDataToFile method for the FileOutputStream and used try-with-resources for fis in the same method where the iterator is used.

Now, the tests run fine on Windows too.

Here are the different approaches I tried:

Attempt 1:

convert method:

FileOutputStream with try-with-resources

FileInputStream with try-with-resources

Error: Stream Closed - because the fis was closed while the iterator still needed it.

Attempt 2:

convert method:

FileOutputStream with try-with-resources

FileInputStream

Error: failed to delete temp directory - because the fis wasn't closed.

Attempt 3:

convert method:

FileOutputStream with try-with-resources

Added FileInputStream as a parameter to the convert method and explicitly closed it in the test method.

Didn't work as expected.

Thanks for pushing this one and evaluating diverse approaches.

llama90 · 2024-06-13T15:11:17Z

@vibhatha @lidavidm lol. Finally, it looks I've resolved the problem!

I would appreciate it if you could review this when you have free time.

comment

vibhatha

I think the changes look okay to me. And using try-with-resources is actually encouraged, may be this upgrade showed an issue in the code?

lidavidm

Thanks for figuring it out! So basically, we weren't properly closing the file in all cases and that stopped Windows from deleting the temp files?

llama90 · 2024-06-15T01:19:22Z

Thanks for figuring it out! So basically, we weren't properly closing the file in all cases and that stopped Windows from deleting the temp files?

File deletion operations differ across operating systems. Specifically, Windows only marks a file for deletion on close. Therefore, it's important to use explicit resource management, such as try-with-resources, to ensure proper release of resources.

reference: @TempDir directory cannot be deleted on Windows with Java 11 junit-team/junit5#2811 (comment)

conbench-apache-arrow · 2024-06-15T09:04:56Z

After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 870b315.

There were 12 benchmark results indicating a performance regression:

Commit Run on test-mac-arm at 2024-06-14 14:37:43Z
- tpch (R) with engine=arrow, format=native, language=R, memory_map=False, query_id=TPCH-07, scale_factor=1
- tpch (R) with engine=arrow, format=native, language=R, memory_map=False, query_id=TPCH-17, scale_factor=1
and 10 more (see the report linked below)

The full Conbench report has more details. It also includes information about 59 possible false positives for unstable benchmarks that are known to sometimes produce them.

llama90 requested a review from lidavidm as a code owner June 8, 2024 16:25

github-actions bot added Component: Java awaiting review Awaiting review labels Jun 8, 2024

llama90 commented Jun 8, 2024

View reviewed changes

github-actions bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Jun 8, 2024

llama90 force-pushed the ARROW-42030 branch 4 times, most recently from a5a328a to 64f8b60 Compare June 9, 2024 15:02

vibhatha reviewed Jun 9, 2024

View reviewed changes

java/adapter/jdbc/src/test/java/org/apache/arrow/adapter/jdbc/h2/JdbcToArrowCharSetTest.java Show resolved Hide resolved

llama90 mentioned this pull request Jun 10, 2024

GH-42025: [Java] Update Unit Tests for Algorithm Module #42029

Merged

7 tasks

llama90 force-pushed the ARROW-42030 branch from 2ad2717 to b323021 Compare June 10, 2024 13:55

lidavidm approved these changes Jun 12, 2024

View reviewed changes

github-actions bot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Jun 12, 2024

llama90 added 9 commits June 12, 2024 22:20

update org.junit.Assert to org.junit.jupiter.api.Assertions for avro

eb39e2d

update org.junit.Assert to org.junit.jupiter.api.Assertions for jdbc

41203ec

update annotations such as Before, ClassRule, TemporaryFolder, Test f…

bb991d2

…or avro

update annotations such as After, Before, Test for jdbc

2e3a62c

update parameterized test (step 1) for jdbc

7ce2273

update parameterized test (step 2) for jdbc

297e5b7

- initize database within the test methods

update org.junit.Assert to org.junit.jupiter.api.Assertions for orc

536f97a

update annotations such as BeforeClass, Rule, TemporaryFolder

803a7d8

perform self-review to add missing access modifier for orc

d5f1375

apply lint

14138d5

llama90 force-pushed the ARROW-42030 branch from c1aa9fe to 14138d5 Compare June 13, 2024 06:43

test try-with-resources

93b80b6

llama90 force-pushed the ARROW-42030 branch 2 times, most recently from 35e7777 to dd84928 Compare June 13, 2024 10:04

test try-with-resources for TestWriteReadAvroRecord

58a81ab

llama90 force-pushed the ARROW-42030 branch 3 times, most recently from bc536e6 to fb22cad Compare June 13, 2024 11:04

llama90 force-pushed the ARROW-42030 branch from fb22cad to 58a81ab Compare June 13, 2024 11:23

llama90 force-pushed the ARROW-42030 branch 2 times, most recently from 8fde75e to b496322 Compare June 13, 2024 13:44

llama90 force-pushed the ARROW-42030 branch from b496322 to a575549 Compare June 13, 2024 14:06

test try-with-resources for AvroToArrowIteratorTest

993e4da

llama90 force-pushed the ARROW-42030 branch from a575549 to 993e4da Compare June 13, 2024 14:11

enhance duplicate

1d4c4d1

llama90 commented Jun 13, 2024

View reviewed changes

vibhatha approved these changes Jun 13, 2024

View reviewed changes

lidavidm approved these changes Jun 14, 2024

View reviewed changes

lidavidm merged commit 870b315 into apache:main Jun 14, 2024
20 checks passed

lidavidm removed the awaiting merge Awaiting merge label Jun 14, 2024

lidavidm mentioned this pull request Jun 14, 2024

[Java] Update Unit Tests for Adapter Module #42030

Closed

This was referenced Jun 18, 2024

GH-42045: [Java] Update Unit Tests for Flight Module #42158

Merged

[Java] Enhance Parameterized tests following JUnit improvements apache/arrow-java#73

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GH-42030: [Java] Update Unit Tests for Adapter Module #42038

GH-42030: [Java] Update Unit Tests for Adapter Module #42038

llama90 commented Jun 8, 2024 •

edited

Loading

github-actions bot commented Jun 8, 2024

llama90 commented Jun 8, 2024

llama90 Jun 8, 2024

vibhatha Jun 9, 2024

vibhatha Jun 9, 2024

llama90 Jun 10, 2024

lidavidm Jun 12, 2024

llama90 commented Jun 9, 2024 •

edited

Loading

vibhatha commented Jun 9, 2024

Using `try-with-resources` Statements for `FileOutputStream` and `FileInputStream`

Separating `FileOutputStream` and `FileInputStream` Usage to Avoid Concurrent Access

vibhatha Jun 9, 2024

lidavidm Jun 10, 2024

llama90 Jun 10, 2024

vibhatha Jun 12, 2024

lidavidm left a comment •

edited

Loading

lidavidm Jun 10, 2024

lidavidm Jun 12, 2024

lidavidm Jun 12, 2024

lidavidm Jun 12, 2024

llama90 Jun 12, 2024

vibhatha Jun 13, 2024

vibhatha Jun 13, 2024

vibhatha Jun 13, 2024

vibhatha commented Jun 13, 2024 •

edited

Loading

llama90 commented Jun 13, 2024

vibhatha commented Jun 13, 2024

llama90 Jun 13, 2024 •

edited

Loading

vibhatha Jun 13, 2024

llama90 commented Jun 13, 2024

vibhatha left a comment

lidavidm left a comment

llama90 commented Jun 15, 2024

conbench-apache-arrow bot commented Jun 15, 2024

GH-42030: [Java] Update Unit Tests for Adapter Module #42038

GH-42030: [Java] Update Unit Tests for Adapter Module #42038

Conversation

llama90 commented Jun 8, 2024 • edited Loading

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

github-actions bot commented Jun 8, 2024

llama90 commented Jun 8, 2024

Reason

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

llama90 commented Jun 9, 2024 • edited Loading

Using try-with-resources Statements for FileOutputStream and FileInputStream

Separating FileOutputStream and FileInputStream Usage to Avoid Concurrent Access

vibhatha commented Jun 9, 2024

Using try-with-resources Statements for FileOutputStream and FileInputStream

Separating FileOutputStream and FileInputStream Usage to Avoid Concurrent Access

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lidavidm left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vibhatha commented Jun 13, 2024 • edited Loading

llama90 commented Jun 13, 2024

vibhatha commented Jun 13, 2024

llama90 Jun 13, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

llama90 commented Jun 13, 2024

vibhatha left a comment

Choose a reason for hiding this comment

lidavidm left a comment

Choose a reason for hiding this comment

llama90 commented Jun 15, 2024

conbench-apache-arrow bot commented Jun 15, 2024

llama90 commented Jun 8, 2024 •

edited

Loading

llama90 commented Jun 9, 2024 •

edited

Loading

Using `try-with-resources` Statements for `FileOutputStream` and `FileInputStream`

Separating `FileOutputStream` and `FileInputStream` Usage to Avoid Concurrent Access

Using `try-with-resources` Statements for `FileOutputStream` and `FileInputStream`

Separating `FileOutputStream` and `FileInputStream` Usage to Avoid Concurrent Access

lidavidm left a comment •

edited

Loading

vibhatha commented Jun 13, 2024 •

edited

Loading

llama90 Jun 13, 2024 •

edited

Loading