-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI][C++][Homebrew] Failed to detect Protobuf by ORC #42149
Comments
I've seen this happening also on non ARM64 jobs, example on this PR for macOS 12: |
I have a customized version of the apache-arrow homebrew recipe that turns on substrait (apache-arrow-substrait) I have been seeing this issue today and I couldn't figure out a workaround, so I'm going to try turning off ORC for myself (which the apache-arrow homebrew recipe currently has anyways). Mostly commenting here since I arbitrarily linked to this issue (and that would probably seem fairly random without any context). |
@wgtmac I looked at this problem and opened an issue for this: https://issues.apache.org/jira/browse/ORC-1732 |
This also has a workaround for https://issues.apache.org/jira/browse/ORC-1732 .
It seems quite a lot of our verification jobs fail due to this issue :
verify-rc-source-cpp-macos-amd64 |
This also has a workaround for https://issues.apache.org/jira/browse/ORC-1732 .
This also has a workaround for https://issues.apache.org/jira/browse/ORC-1732 .
This also has a workaround for https://issues.apache.org/jira/browse/ORC-1732 .
This also has a workaround for https://issues.apache.org/jira/browse/ORC-1732 .
This also has a workaround for https://issues.apache.org/jira/browse/ORC-1732 .
This also has a workaround for https://issues.apache.org/jira/browse/ORC-1732 .
### Rationale for this change This also has a workaround for https://issues.apache.org/jira/browse/ORC-1732 . ### What changes are included in this PR? ORC 2.0.1 has a dependency detection problem. We can't override the detection with ExternalProject but can override the detection with FetchContent. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * GitHub Issue: #42149 Authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Raúl Cumplido <[email protected]>
Issue resolved by pull request 43011 |
### Rationale for this change This also has a workaround for https://issues.apache.org/jira/browse/ORC-1732 . ### What changes are included in this PR? ORC 2.0.1 has a dependency detection problem. We can't override the detection with ExternalProject but can override the detection with FetchContent. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * GitHub Issue: #42149 Authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Raúl Cumplido <[email protected]>
### Rationale for this change This also has a workaround for https://issues.apache.org/jira/browse/ORC-1732 . ### What changes are included in this PR? ORC 2.0.1 has a dependency detection problem. We can't override the detection with ExternalProject but can override the detection with FetchContent. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * GitHub Issue: apache#42149 Authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Raúl Cumplido <[email protected]>
### What changes were proposed in this pull request? Detect Protobuf installed by Homebrew on macOS. ### Why are the changes needed? Deal with the issue discussed [here](apache/arrow#42149) ### How was this patch tested? Test it locally. ### Was this patch authored or co-authored using generative AI tooling? NO Closes #1963 from luffy-zh/ORC-1732. Lead-authored-by: luffy-zh <[email protected]> Co-authored-by: Hao Zou <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
### What changes were proposed in this pull request? Detect Protobuf installed by Homebrew on macOS. ### Why are the changes needed? Deal with the issue discussed [here](apache/arrow#42149) ### How was this patch tested? Test it locally. ### Was this patch authored or co-authored using generative AI tooling? NO Closes #1963 from luffy-zh/ORC-1732. Lead-authored-by: luffy-zh <[email protected]> Co-authored-by: Hao Zou <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit a9e0351) Signed-off-by: Dongjoon Hyun <[email protected]>
Describe the bug, including details regarding any error messages, version, and platform.
ARM64 macOS 14 C++: https://github.com/apache/arrow/actions/runs/9508523884/job/26209983344#step:12:862
Component(s)
C++, Continuous Integration
The text was updated successfully, but these errors were encountered: