-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-42102: [C++][Parquet] Add binary that extracts a footer from a parquet file #42174
Conversation
|
2a86a42
to
d6d3657
Compare
Windows build keeps failing. Could you advice? It seems it can't find library |
Just a high-level comment on usability. I don't think any binaries are currently packaged in release channels so if we want this to be easier to use we should consider embedding it in the library with python bindings |
You mean writing this in python and shipping as a python script? |
FYI: deb and RPM include binaries: |
I didn't realize this. I guess I was thinking of the pyarrow/R libraries as the primary distribution source.
I was thinking of just include the functionality in the pyarrow arrow library by including C++ as part of the library and wrapping in python. given that there is some packaging that does include the binaries this might be less of an issue. |
Given that tools are packages in deb and rpm this covers the majority of linux. |
Is this ready for merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General looks ok to me, so this patch would extract a footer with "scrub" might be used?
Yes, the purpose is to build a repository of large/slow to parse footers and guide the design of better parquet metadata representation. |
Friendly ping. Can this be merged? |
@github-actions crossbow submit -g cpp |
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @alkis could you review the changes I've made to make sure they're ok to you?
Thanks a ton for the fixes! I reverted the JSON fix and named the optional properly as |
Ah, fair enough. |
@github-actions crossbow submit -g cpp |
Revision: 44f9768 Submitted crossbow builds: ursacomputing/crossbow @ actions-366196b72e |
I have one more nit coming in. |
Thanks @alkis . I'm waiting for CI and will merge if ok. |
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit d21a924. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 4 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Rationale for this change
This binary will make it a lot easier for customers to share their parquet metadata with the community so that we can build a repository of footers that can be used for advancing the state of metadata in parquet.
What changes are included in this PR?
Usage from the file binary itself:
Are these changes tested?
Manually on existing parquet files.
Are there any user-facing changes?
No.