Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Java] Update Maven project details #43229

Closed
laurentgo opened this issue Jul 11, 2024 · 1 comment
Closed

[Java] Update Maven project details #43229

laurentgo opened this issue Jul 11, 2024 · 1 comment
Assignees
@laurentgo
Labels
Component: Java Type: enhancement
Milestone
18.0.0

Comments

@laurentgo
Copy link
Contributor

laurentgo commented Jul 11, 2024 •
edited
Loading

Describe the enhancement requested

Follow up of the conversation at #43191

Information generated and published to Apache Maven repository/Maven Central is either missing or incorrect:

  • Modules under maven/ and bom/ directories do not have project url, mailing list, scm and issue management links
  • Children modules have incorrect project and scm urls as Maven appends by default the name of the name of the artifact to the url from the parent module
  • ${project.scm.tag} hasn't been updated and is still apache-arrow-2.0.0

Component(s)

Java
laurentgo added a commit to laurentgo/arrow that referenced this issue Jul 11, 2024
@laurentgo
apacheGH-43229: [Java] Update Maven project info
c3cd402 
Some Maven modules are missing project information like the website url,
the mailing lists, and scm and issues url

Other may have incorrect links because of the way Maven interpolates
those values at build tim

Update/Fix Maven project information for all modules:
* Add project url, mailing lists, scm and issueManagement information to
  bom and maven parent modules
* Fix top-level parent by preventing Maven to rewrite project url, and
  scm connections/urls based on the module hierarchy
* Change project.scm.tag to `main` and update version change script to
  also change the tag value to `apache-arrow-${version}`
@github-actions github-actions bot mentioned this issue Jul 11, 2024
Merged
lidavidm pushed a commit that referenced this issue Jul 17, 2024
@laurentgo
GH-43229: [Java] Update Maven project info (#43231)
de17643 
### Rationale for this change

Some Maven modules are missing project information like the website url, the mailing lists, and scm and issues url

Other may have incorrect links because of the way Maven interpolates those values at build time

### What changes are included in this PR?

Update/Fix Maven project information for all modules:
* Add project url, mailing lists, scm and issueManagement information to bom and maven parent modules
* Fix top-level parent by preventing Maven to rewrite project url, and scm connections/urls based on the module hierarchy
* Change project.scm.tag to `main` and update version change script to also change the tag value to `apache-arrow-${version}`

### Are these changes tested?

CI/CD only

### Are there any user-facing changes?

No
* GitHub Issue: #43229

Authored-by: Laurent Goujon <[email protected]>
Signed-off-by: David Li <[email protected]>
@lidavidm lidavidm added this to the 18.0.0 milestone Jul 17, 2024
@lidavidm
Copy link
Member

Issue resolved by pull request 43231
#43231

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@laurentgo laurentgo

Labels
Component: Java Type: enhancement
Projects
None yet
Milestone
18.0.0
Development

No branches or pull requests
2 participants
@lidavidm @laurentgo