-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[C#] Schema should be optional on FlightInfo #43672
Comments
### Rationale for this change Schema is not required on a FlightInfo message and sometimes needs to be lazily evaluated on the server. This PR allows schema to be null on the FlightInfo since it will be picked up later when requests with those tickets are made. ### What changes are included in this PR? ### Are these changes tested? Yes, added a test to confirm this behaviour ### Are there any user-facing changes? * GitHub Issue: #43672 Authored-by: neilglover <[email protected]> Signed-off-by: Curt Hagenlocher <[email protected]>
Issue resolved by pull request 43673 |
…43673) ### Rationale for this change Schema is not required on a FlightInfo message and sometimes needs to be lazily evaluated on the server. This PR allows schema to be null on the FlightInfo since it will be picked up later when requests with those tickets are made. ### What changes are included in this PR? ### Are these changes tested? Yes, added a test to confirm this behaviour ### Are there any user-facing changes? * GitHub Issue: apache#43672 Authored-by: neilglover <[email protected]> Signed-off-by: Curt Hagenlocher <[email protected]>
Is it possible to have a release candidate for this fix? |
There's no existing process by which prereleases get published to nuget.org, so if you need something before the final 18.0.0 release you'd need to build it yourself from source. |
…43673) ### Rationale for this change Schema is not required on a FlightInfo message and sometimes needs to be lazily evaluated on the server. This PR allows schema to be null on the FlightInfo since it will be picked up later when requests with those tickets are made. ### What changes are included in this PR? ### Are these changes tested? Yes, added a test to confirm this behaviour ### Are there any user-facing changes? * GitHub Issue: apache#43672 Authored-by: neilglover <[email protected]> Signed-off-by: Curt Hagenlocher <[email protected]>
@CurtHagenlocher do you have a date for the 18.0.0 release? |
Code freeze is at the end of September and the release will be sometime during October. We can't really predict a date because it depends in part on how the testing goes. |
Is there a reason not to have release candidates before that final release? It would seem to make sense from a stability perspective and also from an end user perspective. Waiting at worse case an entire quarter seems sub-optimal and each person then needs to fork the repo and manage builds etc Happy to make a contribution if that's a good idea but not sure what would be involved. |
Yes, there are absolutely one or more official release candidates that are used for testing. I believe these would even be signed, if that's an issue. They are not, however, published to nuget.org. As I understand it, doing so would likely be a significant process change because I think the release candidates are exactly that: something that will be released and published if testing is successful -- versus artifacts that have been explicitly marked as non-release. |
Describe the enhancement requested
Similar to 37553
The idea being that the Schema is not a required field for FlightInfo. The Schema can be sent as part of the messages in the subsequent request.
Component(s)
C#
The text was updated successfully, but these errors were encountered: