Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C#][Integration] Set up integration testing of C# Flight #44361

Closed
adamreeve opened this issue Oct 9, 2024 · 2 comments
Closed

[C#][Integration] Set up integration testing of C# Flight #44361

adamreeve opened this issue Oct 9, 2024 · 2 comments

Comments

@adamreeve
Copy link
Contributor

Describe the enhancement requested

Archery includes Flight integration tests but not for C#. These would be useful for catching issues like #44360, although it appears that DoExchange is not currently included in the integration tests.

Component(s)

C#, Integration

@adamreeve
Copy link
Contributor Author

take

CurtHagenlocher pushed a commit that referenced this issue Oct 15, 2024
…44377)

### Rationale for this change

See #44361. This allows testing compatibility of the .NET Flight implementation with other Flight implementations.

### What changes are included in this PR?

* Adds a new `Apache.Arrow.Flight.IntegrationTest` project that can run in server or client mode for Flight integration tests.
* Includes the integration tests that send then retrieve data defined in JSON files, but doesn't add any of the named scenarios
* Configures archery to include C# in the Flight integration tests, but skip all the named scenarios
* Also skips tests that use dictionary data due to #38045, and the empty data test due to #44363

### Are these changes tested?

These changes are tests.

### Are there any user-facing changes?

No
* GitHub Issue: #44361

Authored-by: Adam Reeve <[email protected]>
Signed-off-by: Curt Hagenlocher <[email protected]>
@CurtHagenlocher
Copy link
Contributor

Issue resolved by pull request 44377
#44377

@CurtHagenlocher CurtHagenlocher added this to the 19.0.0 milestone Oct 15, 2024
@assignUser assignUser modified the milestones: 19.0.0, 18.1.0 Nov 8, 2024
amoeba pushed a commit that referenced this issue Nov 11, 2024
…44377)

### Rationale for this change

See #44361. This allows testing compatibility of the .NET Flight implementation with other Flight implementations.

### What changes are included in this PR?

* Adds a new `Apache.Arrow.Flight.IntegrationTest` project that can run in server or client mode for Flight integration tests.
* Includes the integration tests that send then retrieve data defined in JSON files, but doesn't add any of the named scenarios
* Configures archery to include C# in the Flight integration tests, but skip all the named scenarios
* Also skips tests that use dictionary data due to #38045, and the empty data test due to #44363

### Are these changes tested?

These changes are tests.

### Are there any user-facing changes?

No
* GitHub Issue: #44361

Authored-by: Adam Reeve <[email protected]>
Signed-off-by: Curt Hagenlocher <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants