GH-44950: [C++] Bump minimum CMake version to 3.25 #44989

raulcd · 2024-12-10T11:06:33Z

This is currently under development. I am only exercising CI to find out what things would require to be updated
This is still being decided and a decision hasn't been finalized yet.

Rationale for this change

We want to upgrade our CMake version to 3.25 as discussed on the ML:
https://lists.apache.org/thread/h8jp16ktrj11fmjmjhlg6xvkvv9wzvjk

What changes are included in this PR?

TBD

Are these changes tested?

Yes, via CI.

Are there any user-facing changes?

Yes, the minimum CMake version to be used to build Arrow is bumped to 3.25.
This PR includes breaking changes to build systems.

GitHub Issue: [C++] Bump required CMake version #44950

github-actions · 2024-12-10T11:07:01Z

⚠️ GitHub issue #44950 has been automatically assigned in GitHub to PR creator.

raulcd · 2024-12-10T15:28:45Z

I am unsure on how to fix the remaining failures for R.
For the gcc 12 job I am unsure why it is failing and for the Windows C++ RTools 40 ucrt64 it seems we install CMake from MINGW here but I am not sure if this is necessary or can be updated.
https://github.com/apache/arrow/blob/main/ci/scripts/PKGBUILD#L39

Of course this is the initial CI (we also have to update all the extended CI jobs for crossbow).

h-vetinari · 2024-12-11T04:46:18Z

For the gcc 12 job I am unsure why it is failing

Updating the CMake lower bound will flip the default of several policies from legacy to new; sounds like you might be relying on legacy behaviour there in some way (once you figure out which policy is at fault, there's usually a migration path to keep the old behaviour)

raulcd · 2024-12-11T10:22:42Z

ok, it seems R forces the builds to use the CMake provided on the images:

**** Not using cmake found at /bin/cmake
Error in .make_numeric_version(x, strict, .standard_regexps()$valid_numeric_version) : 
  invalid non-character version specification 'x' (type: double)
Calls: build_libarrow ... as.numeric_version -> numeric_version -> .make_numeric_version
Execution halted

@jonkeane @assignUser @amoeba will this be an issue for CRAN? Are we somehow forced to the CMake version on those images?

root@03abb5b759ba:/# /bin/cmake --version
cmake version 3.22.1

CMake suite maintained and supported by Kitware (kitware.com/cmake).

assignUser · 2024-12-11T11:07:44Z

I went through the logs of our recent checks on cran and only one is using a version < 3.25 and that seems more incidental then purposely as it's the r-odrel arm64 but the intel version has 3.26

So I don't think we should be forced to use that cmake version, additionally we have a function that fetches current cmake if an unsuited version is found but apparently there is an issue with it as seen above. IIRC there was a change to numeric version in one of the las R Versions that is causing this? I'll have a look.

nealrichardson · 2024-12-11T14:11:13Z

It's possible the version comparison error is from this: https://github.com/apache/arrow/pull/44989/files#diff-935746c34b16289a07b0d9bf7642dbd268b18059b6187f7cdec7c464be47a3deL731-L743

cmake_version <- function(cmd = "cmake") {
  tryCatch(
    {
      raw_version <- system(paste(cmd, "--version"), intern = TRUE, ignore.stderr = TRUE)
      pat <- ".* ([0-9\\.]+).*?"
      which_line <- grep(pat, raw_version)
      package_version(sub(pat, "\\1", raw_version[which_line]))
    },
    error = function(e) {
      return(0)
    }
  )
}

The error case should probably return("0")

nealrichardson · 2024-12-11T14:15:02Z

Two other places in the R nixlibs.R script worth updating:

https://github.com/apache/arrow/pull/44989/files#diff-935746c34b16289a07b0d9bf7642dbd268b18059b6187f7cdec7c464be47a3deR643 (bump to the latest? this pinned version was just latest at the last point we updated it)
https://github.com/apache/arrow/pull/44989/files#diff-935746c34b16289a07b0d9bf7642dbd268b18059b6187f7cdec7c464be47a3deR701 (maybe just remove the default value for the input, I think it's only called passing the value in)

pitrou · 2024-12-11T14:16:16Z

The error case should probably return("0")

It would probably be more forward-looking to avoid the error entirely. Why does the function fail parsing the CMake version? Can we add cmake --version somewhere in the GH workflow?

nealrichardson · 2024-12-11T14:31:07Z

The error case should probably return("0")

It would probably be more forward-looking to avoid the error entirely. Why does the function fail parsing the CMake version? Can we add cmake --version somewhere in the GH workflow?

I could be remembering wrong, but I believe the function is used to check for cmake of a certain version, and this is to be robust to where cmake may not be installed or not found at the path provided. It does not emit an error, it traps it.

This might not be where the error is coming from that was observed in CI, I was just browsing the source to see where you might get a numeric version error. Looking again, and reading the output it produced, I think we're hitting this: https://github.com/apache/arrow/pull/44989/files#diff-935746c34b16289a07b0d9bf7642dbd268b18059b6187f7cdec7c464be47a3deL718

      } else {
        # Keep trying
        lg("Not using cmake found at %s", path, .indent = "****")
        if (found_version > 0) {
          lg("Version >= %s required; found %s", version_required, found_version, .indent = "*****")
        } else {

should be found_version > "0". We must not have been running into this before because the "found_version" was always sufficient if found, and if it wasn't found, we were returning a numeric 0 which works in this comparison.

(To be clear, we need to fix both this and the return("0") above.)

jonkeane · 2024-12-12T15:45:56Z

.env

@@ -54,6 +54,7 @@ UBUNTU=22.04

 # Default versions for various dependencies
 CLANG_TOOLS=14
+CMAKE=3.25.0


Would it be possible (and also would it be advisable...) to call this CMAKE_VERSION instead? One of the R failures I suspect might be due to us looking to CMAKE for a path to the cmake executable itself at

arrow/r/tools/nixlibs.R

Line 695 in bcb5bd3

Sys.getenv("CMAKE"),

(though I don't have a full traceback I'm not 100% certain on that)

Aaah I didn't see the previous comments on the PR (sorry, I must have had a tab open and didn't refresh!) but I suspect this here is the answer to:

It would probably be more forward-looking to avoid the error entirely. Why does the function fail parsing the CMake version?

…h to not require platform argument

…uire the existing version to be bumped

raulcd · 2024-12-19T13:15:50Z

After a bunch of trial and error, I seem to be stuck with the following issue if I override the CMake version to be used to either a manually 3.25.0 installed or using the latest available (3.31) on msys2:

-- Found hdfs.h at: D:/a/arrow/arrow/cpp/thirdparty/hadoop/include/hdfs.h
CMake Error at C:/rtools40/ucrt64/lib/cmake/AWSSDK/AWSSDKConfig.cmake:119 (while):
  while() given incorrect arguments:

    "NOT" "TEMP_NAME" "STREQUAL"

  Unknown arguments specified
Call Stack (most recent call first):
  cmake_modules/FindAWSSDKAlt.cmake:36 (find_package)
  cmake_modules/ThirdpartyToolchain.cmake:294 (find_package)
  cmake_modules/ThirdpartyToolchain.cmake:5389 (resolve_dependency)
  CMakeLists.txt:546 (include)

I am trying some things, like using an updated aws-sdk-cpp version, but I am unsure where to go from there

nealrichardson · 2024-12-19T14:14:19Z

The aws-sdk-cpp it's using is coming from https://github.com/r-windows/rtools-packages/tree/master/mingw-w64-aws-sdk-cpp

If you need to update it, I think you'll have to drop it from the dependencies that get downloaded in our PKGBUILD and make it dependency source=BUNDLED. Doesn't look like we're able to make any updates happen to that repo.

cc @assignUser, in case you wanted to start pushing on the MXE direction again as an alternative 🙃

amoeba · 2024-12-20T01:30:28Z

I spent some time trying to build aws-sdk-cpp under Rtools40 and got stuck building aws-c-io. I put my progress in a gist which includes my steps, a patch for aws-c-common, and my build log for aws-c-io.

amoeba · 2024-12-23T03:01:45Z

Update on fixing the Rtools40 build: I've created a set of patches and the awssdk source build works now so I think the approach you were taking @raulcd will work. I'm running into an issue where the patches I record don't re-apply when I rebuild so I'm working on figuring that out now.

amoeba · 2024-12-23T07:01:48Z

I figured out my issue above and now have what looks like a working set of patches so we can build the AWS SDK under Rtools40. My changes are over on raulcd#90. Still needs some work but hopefully this helps unblock this PR.

Try fixing patch

raulcd · 2024-12-23T13:48:34Z

Thanks @amoeba for the patches! I had to tweak a little but I did make some more progress. The R / AMD64 Windows C++ RTools 40 ucrt64 is now successful with bundled AWS but the related R / AMD64 Windows R release job, which validates the built package, is currently failing when trying to install the new Arrow package. It seems to be missing some symbols on the new bundled libraries. Anyone has an idea?

g++ -shared -s -static-libgcc -o arrow.dll tmp.def RTasks.o altrep.o array.o array_to_vector.o arraydata.o arrowExports.o bridge.o buffer.o chunkedarray.o compression.o compute-exec.o compute.o config.o csv.o dataset.o datatype.o expression.o extension-impl.o feather.o field.o filesystem.o io.o json.o memorypool.o message.o parquet.o r_to_arrow.o recordbatch.o recordbatchreader.o recordbatchwriter.o safe-call-into-r-impl.o scalar.o schema.o symbols.o table.o threadpool.o type_infer.o -L../windows/arrow-18.1.0.9000/lib-13.3.0/x64 -L../windows/arrow-18.1.0.9000/lib/x64-ucrt -larrow_dataset -larrow_acero -lparquet -larrow -larrow_bundled_dependencies -lutf8proc -lthrift -lsnappy -lz -lzstd -llz4 -lbz2 -lbrotlienc -lbrotlidec -lbrotlicommon -lole32 -lbcrypt -lpsapi -lcrypto -lcrypt32 -lre2 -luserenv -lversion -lws2_32 -lbcrypt -lwininet -lwinhttp -lcurl -lnormaliz -lssh2 -lgdi32 -lssl -lcrypto -lcrypt32 -lwldap32 -lz -lws2_32 -lnghttp2 -ldbghelp -LC:/rtools44/x86_64-w64-mingw32.static.posix/lib/x64 -LC:/rtools44/x86_64-w64-mingw32.static.posix/lib -LC:/R/bin/x64 -lR
C:\rtools44\x86_64-w64-mingw32.static.posix\bin/ld.exe: ../windows/arrow-18.1.0.9000/lib/x64-ucrt/libarrow_bundled_dependencies.a(file.c.obj):(.text+0x1110): undefined reference to `__imp_PathFileExistsW'
C:\rtools44\x86_64-w64-mingw32.static.posix\bin/ld.exe: ../windows/arrow-18.1.0.9000/lib/x64-ucrt/libarrow_bundled_dependencies.a(secure_channel_tls_handler.c.obj):(.text+0xcb): undefined reference to `QueryContextAttributesA'
C:\rtools44\x86_64-w64-mingw32.static.posix\bin/ld.exe: ../windows/arrow-18.1.0.9000/lib/x64-ucrt/libarrow_bundled_dependencies.a(secure_channel_tls_handler.c.obj):(.text+0x694): undefined reference to `QueryContextAttributesA'
C:\rtools44\x86_64-w64-mingw32.static.posix\bin/ld.exe: ../windows/arrow-18.1.0.9000/lib/x64-ucrt/libarrow_bundled_dependencies.a(secure_channel_tls_handler.c.obj):(.text+0xb6a): undefined reference to `DecryptMessage'
C:\rtools44\x86_64-w64-mingw32.static.posix\bin/ld.exe: ../windows/arrow-18.1.0.9000/lib/x64-ucrt/libarrow_bundled_dependencies.a(secure_channel_tls_handler.c.obj):(.text+0x100e): undefined reference to `QueryContextAttributesA'
C:\rtools44\x86_64-w64-mingw32.static.posix\bin/ld.exe: ../windows/arrow-18.1.0.9000/lib/x64-ucrt/libarrow_bundled_dependencies.a(secure_channel_tls_handler.c.obj):(.text+0x12bd): undefined reference to `EncryptMessage'
C:\rtools44\x86_64-w64-mingw32.static.posix\bin/ld.exe: ../windows/arrow-18.1.0.9000/lib/x64-ucrt/libarrow_bundled_dependencies.a(secure_channel_tls_handler.c.obj):(.text+0x1869): undefined reference to `__imp_ApplyControlToken'
C:\rtools44\x86_64-w64-mingw32.static.posix\bin/ld.exe: ../windows/arrow-18.1.0.9000/lib/x64-ucrt/libarrow_bundled_dependencies.a(secure_channel_tls_handler.c.obj):(.text+0x192a): undefined reference to `InitializeSecurityContextA'
C:\rtools44\x86_64-w64-mingw32.static.posix\bin/ld.exe: ../windows/arrow-18.1.0.9000/lib/x64-ucrt/libarrow_bundled_dependencies.a(secure_channel_tls_handler.c.obj):(.text+0x1ab3): undefined reference to `__imp_DeleteSecurityContext'
C:\rtools44\x86_64-w64-mingw32.static.posix\bin/ld.exe: ../windows/arrow-18.1.0.9000/lib/x64-ucrt/libarrow_bundled_dependencies.a(secure_channel_tls_handler.c.obj):(.text+0x1ae2): undefined reference to `__imp_DeleteSecurityContext'
C:\rtools44\x86_64-w64-mingw32.static.posix\bin/ld.exe: ../windows/arrow-18.1.0.9000/lib/x64-ucrt/libarrow_bundled_dependencies.a(secure_channel_tls_handler.c.obj):(.text+0x1bc6): undefined reference to `AcquireCredentialsHandleA'
C:\rtools44\x86_64-w64-mingw32.static.posix\bin/ld.exe: ../windows/arrow-18.1.0.9000/lib/x64-ucrt/libarrow_bundled_dependencies.a(secure_channel_tls_handler.c.obj):(.text+0x274b): undefined reference to `__imp_AcceptSecurityContext'
C:\rtools44\x86_64-w64-mingw32.static.posix\bin/ld.exe: ../windows/arrow-18.1.0.9000/lib/x64-ucrt/libarrow_bundled_dependencies.a(secure_channel_tls_handler.c.obj):(.text+0x27c5): undefined reference to `FreeContextBuffer'
C:\rtools44\x86_64-w64-mingw32.static.posix\bin/ld.exe: ../windows/arrow-18.1.0.9000/lib/x64-ucrt/libarrow_bundled_dependencies.a(secure_channel_tls_handler.c.obj):(.text+0x2a0f): undefined reference to `FreeContextBuffer'
C:\rtools44\x86_64-w64-mingw32.static.posix\bin/ld.exe: ../windows/arrow-18.1.0.9000/lib/x64-ucrt/libarrow_bundled_dependencies.a(secure_channel_tls_handler.c.obj):(.text+0x2be0): undefined reference to `InitializeSecurityContextA'
C:\rtools44\x86_64-w64-mingw32.static.posix\bin/ld.exe: ../windows/arrow-18.1.0.9000/lib/x64-ucrt/libarrow_bundled_dependencies.a(secure_channel_tls_handler.c.obj):(.text+0x2c56): undefined reference to `FreeContextBuffer'
C:\rtools44\x86_64-w64-mingw32.static.posix\bin/ld.exe: ../windows/arrow-18.1.0.9000/lib/x64-ucrt/libarrow_bundled_dependencies.a(secure_channel_tls_handler.c.obj):(.text+0x2e59): undefined reference to `FreeContextBuffer'
C:\rtools44\x86_64-w64-mingw32.static.posix\bin/ld.exe: ../windows/arrow-18.1.0.9000/lib/x64-ucrt/libarrow_bundled_dependencies.a(secure_channel_tls_handler.c.obj):(.text+0x2fa2): undefined reference to `__imp_AcceptSecurityContext'
C:\rtools44\x86_64-w64-mingw32.static.posix\bin/ld.exe: ../windows/arrow-18.1.0.9000/lib/x64-ucrt/libarrow_bundled_dependencies.a(secure_channel_tls_handler.c.obj):(.text+0x309b): undefined reference to `FreeContextBuffer'
C:\rtools44\x86_64-w64-mingw32.static.posix\bin/ld.exe: ../windows/arrow-18.1.0.9000/lib/x64-ucrt/libarrow_bundled_dependencies.a(secure_channel_tls_handler.c.obj):(.text+0x31e3): undefined reference to `QueryContextAttributesA'
C:\rtools44\x86_64-w64-mingw32.static.posix\bin/ld.exe: ../windows/arrow-18.1.0.9000/lib/x64-ucrt/libarrow_bundled_dependencies.a(secure_channel_tls_handler.c.obj):(.text+0x342a): undefined reference to `FreeContextBuffer'
C:\rtools44\x86_64-w64-mingw32.static.posix\bin/ld.exe: ../windows/arrow-18.1.0.9000/lib/x64-ucrt/libarrow_bundled_dependencies.a(secure_channel_tls_handler.c.obj):(.text+0x3447): undefined reference to `QueryContextAttributesA'
C:\rtools44\x86_64-w64-mingw32.static.posix\bin/ld.exe: ../windows/arrow-18.1.0.9000/lib/x64-ucrt/libarrow_bundled_dependencies.a(secure_channel_tls_handler.c.obj):(.text+0x381c): undefined reference to `InitializeSecurityContextA'
C:\rtools44\x86_64-w64-mingw32.static.posix\bin/ld.exe: ../windows/arrow-18.1.0.9000/lib/x64-ucrt/libarrow_bundled_dependencies.a(secure_channel_tls_handler.c.obj):(.text+0x3913): undefined reference to `FreeContextBuffer'
C:\rtools44\x86_64-w64-mingw32.static.posix\bin/ld.exe: ../windows/arrow-18.1.0.9000/lib/x64-ucrt/libarrow_bundled_dependencies.a(secure_channel_tls_handler.c.obj):(.text+0x3a9d): undefined reference to `QueryContextAttributesA'
C:\rtools44\x86_64-w64-mingw32.static.posix\bin/ld.exe: ../windows/arrow-18.1.0.9000/lib/x64-ucrt/libarrow_bundled_dependencies.a(secure_channel_tls_handler.c.obj):(.text+0x3c9a): undefined reference to `FreeContextBuffer'
C:\rtools44\x86_64-w64-mingw32.static.posix\bin/ld.exe: ../windows/arrow-18.1.0.9000/lib/x64-ucrt/libarrow_bundled_dependencies.a(secure_channel_tls_handler.c.obj):(.text+0x3cb7): undefined reference to `QueryContextAttributesA'
C:\rtools44\x86_64-w64-mingw32.static.posix\bin/ld.exe: ../windows/arrow-18.1.0.9000/lib/x64-ucrt/libarrow_bundled_dependencies.a(windows_pki_utils.c.obj):(.text+0x1825): undefined reference to `NCryptOpenStorageProvider'
C:\rtools44\x86_64-w64-mingw32.static.posix\bin/ld.exe: ../windows/arrow-18.1.0.9000/lib/x64-ucrt/libarrow_bundled_dependencies.a(windows_pki_utils.c.obj):(.text+0x1884): undefined reference to `NCryptImportKey'
C:\rtools44\x86_64-w64-mingw32.static.posix\bin/ld.exe: ../windows/arrow-18.1.0.9000/lib/x64-ucrt/libarrow_bundled_dependencies.a(windows_pki_utils.c.obj):(.text+0x1bed): undefined reference to `NCryptFreeObject'
C:\rtools44\x86_64-w64-mingw32.static.posix\bin/ld.exe: ../windows/arrow-18.1.0.9000/lib/x64-ucrt/libarrow_bundled_dependencies.a(windows_pki_utils.c.obj):(.text+0x1bf7): undefined reference to `NCryptFreeObject'
collect2.exe: error: ld returned 1 exit status

r/configure.win

Co-authored-by: Bryce Mecum <[email protected]>

r/configure.win

amoeba · 2024-12-23T22:05:17Z

I made one more change and CI looks better now. @raulcd

raulcd · 2024-12-23T22:28:59Z

I made one more change and CI looks better now.

Awesome @amoeba ! I'll spend some time to trigger and fix extended CI (crossbow tasks) and we can move this to ready for review

nealrichardson

Thanks for persisting with this. Just a few notes, mainly about leaving more breadcrumbs for us for when this inevitably breaks again.

nealrichardson · 2024-12-24T19:50:59Z

r/configure.win

-            -laws-cpp-sdk-cognito-identity -laws-cpp-sdk-sts -laws-cpp-sdk-s3 \
-            -laws-cpp-sdk-core -laws-c-event-stream -laws-checksums -laws-c-common \
-            -luserenv -lversion -lws2_32 -lbcrypt -lwininet -lwinhttp"
+  # AWS specific libs for Windows are bundled


Suggested change

# AWS specific libs for Windows are bundled

# We build aws-sdk-cpp bundled now, so the AWS libs are included in arrow_bundled_dependencies

# but we also need to include these Windows system libraries

nealrichardson · 2024-12-24T19:53:07Z

ci/scripts/r_windows_build.sh

 # Uncomment L38-41 if you're testing a new rtools dependency that hasn't yet sync'd to CRAN
 # curl https://raw.githubusercontent.com/r-windows/rtools-packages/master/pacman.conf > /etc/pacman.conf
+# cp /etc/pacman.conf /etc/pacman.conf.bak
+# curl https://raw.githubusercontent.com/r-windows/rtools-packages/master/pacman.conf > /etc/pacman.conf
+# cat /etc/pacman.conf
 # curl -OSsl "http://repo.msys2.org/msys/x86_64/msys2-keyring-r21.b39fb11-1-any.pkg.tar.xz"
 # pacman -U --noconfirm msys2-keyring-r21.b39fb11-1-any.pkg.tar.xz && rm msys2-keyring-r21.b39fb11-1-any.pkg.tar.xz
 # pacman --noconfirm -Scc

+# pacman --noconfirm -Syy
+# pacman --noconfirm -S ${MINGW_PACKAGE_PREFIX}-cmake
+
+#Try reverting to the original pacman.conf
+# cp /etc/pacman.conf.bak /etc/pacman.conf
+# cat /etc/pacman.conf


As discussed, this comment is no longer valid because the rtools pacman setup is no longer maintained.

Suggested change

# Uncomment L38-41 if you're testing a new rtools dependency that hasn't yet sync'd to CRAN

# curl https://raw.githubusercontent.com/r-windows/rtools-packages/master/pacman.conf > /etc/pacman.conf

# cp /etc/pacman.conf /etc/pacman.conf.bak

# curl https://raw.githubusercontent.com/r-windows/rtools-packages/master/pacman.conf > /etc/pacman.conf

# cat /etc/pacman.conf

# curl -OSsl "http://repo.msys2.org/msys/x86_64/msys2-keyring-r21.b39fb11-1-any.pkg.tar.xz"

# pacman -U --noconfirm msys2-keyring-r21.b39fb11-1-any.pkg.tar.xz && rm msys2-keyring-r21.b39fb11-1-any.pkg.tar.xz

# pacman --noconfirm -Scc

# pacman --noconfirm -Syy

# pacman --noconfirm -S ${MINGW_PACKAGE_PREFIX}-cmake

#Try reverting to the original pacman.conf

# cp /etc/pacman.conf.bak /etc/pacman.conf

# cat /etc/pacman.conf

nealrichardson · 2024-12-24T19:54:15Z

ci/scripts/PKGBUILD

@@ -119,7 +117,9 @@ build() {
    -DCMAKE_BUILD_TYPE="release" \
    -DCMAKE_INSTALL_PREFIX=${MINGW_PREFIX} \
    -DCMAKE_UNITY_BUILD=OFF \
-    -DCMAKE_VERBOSE_MAKEFILE=ON
+    -DCMAKE_VERBOSE_MAKEFILE=ON \
+    -DAWSSDK_SOURCE=BUNDLED \


Move -DAWSSDK_SOURCE=BUNDLED \ up so we stay sorted?

nealrichardson · 2024-12-24T19:55:06Z

ci/scripts/PKGBUILD

-    -DCMAKE_VERBOSE_MAKEFILE=ON
+    -DCMAKE_VERBOSE_MAKEFILE=ON \
+    -DAWSSDK_SOURCE=BUNDLED \
+    -DARROW_USE_CCACHE=OFF


Is this needed or just part of debugging? If it's important, maybe leave a comment explaining why?

We might try CI with this removed. I'll do that in a sec.

One of the AWS EPs was failing with a ccache error about not being able to make temporary files and I tracked it down to a bug that affects older version of ccache (which we have here currently). This was my workaround.

I'll test in CI without this and, if we need it, I'll put a comment.

nealrichardson · 2024-12-24T19:57:24Z

ci/scripts/PKGBUILD

@@ -83,7 +81,7 @@ build() {
  # segfaults in tests

  MSYS2_ARG_CONV_EXCL="-DCMAKE_INSTALL_PREFIX=" \


This "-DCMAKE_INSTALL_PREFIX=" looks odd up here--why would it go before the call to cmake itself? And we also have -DCMAKE_INSTALL_PREFIX=${MINGW_PREFIX} below. (I know y'all didn't touch it in this PR, just observing.)

nealrichardson · 2024-12-24T19:59:02Z

ci/scripts/PKGBUILD

@@ -83,7 +81,7 @@ build() {
  # segfaults in tests

  MSYS2_ARG_CONV_EXCL="-DCMAKE_INSTALL_PREFIX=" \
-    ${MINGW_PREFIX}/bin/cmake.exe \
+    "${PROGRAMFILES}\CMake\bin\cmake.exe" \


I feel like this deserves a comment explaining where this comes from, and/or passing in path-to-cmake via env var or something so that it's explicitly set.

ci/scripts/PKGBUILD

github-actions bot added Component: R Component: C++ Component: Python Component: MATLAB Component: Documentation awaiting committer review Awaiting committer review labels Dec 10, 2024

raulcd force-pushed the GH-44950 branch 2 times, most recently from a2f952c to 81b112a Compare December 10, 2024 11:31

jonkeane reviewed Dec 12, 2024

View reviewed changes

github-actions bot added awaiting changes Awaiting changes and removed awaiting committer review Awaiting committer review labels Dec 12, 2024

raulcd added 8 commits December 13, 2024 12:13

apacheGH-44950: [C++] Bump minimum CMake version to 3.25

f6ca263

Try installing CMake 3.25 manually on Ubuntu

4e58214

Install cmake in linux-apt-lint.dockerfile and update install_cmake.s…

5465906

…h to not require platform argument

Install CMake 3.25.0 on several Ubuntu jobs and Windows jobs that req…

6be9597

…uire the existing version to be bumped

Several fixes to install_cmake

ecd437e

Some more fixes and upgrade minimal examples to use Ubuntu 24.04

00f66f1

Some more fixes for R

8b482b5

Update from CMAKE to CMAKE_VERSION

c62ecd0

raulcd force-pushed the GH-44950 branch from bcb5bd3 to c62ecd0 Compare December 13, 2024 11:16

github-actions bot removed the awaiting changes Awaiting changes label Dec 13, 2024

raulcd added 3 commits December 19, 2024 13:32

CMake should be in the path

39e8572

Debug new CMake location

d9e0c2c

Try with C:\Program Files\CMake\bin\cmake.exe

e2b0c6e

Just testing at this point

17c0d57

raulcd force-pushed the GH-44950 branch from 280c0cd to 17c0d57 Compare December 19, 2024 15:09

amoeba mentioned this pull request Dec 20, 2024

GH-44950: My WIP changes for Rtools raulcd/arrow#90

Merged

amoeba and others added 4 commits December 23, 2024 10:14

Bundle AWSSDK under RTools (#90)

371c06f

Check for mingw

63e8847

Check Windows compiler

820b285

Try modifying patch due to redefinition

ceeab3d

Try fixing patch

raulcd force-pushed the GH-44950 branch from e06d9c3 to ceeab3d Compare December 23, 2024 10:50

raulcd added 3 commits December 23, 2024 12:22

AWS is bundled on Windows R now, do not use MSYS libraries

84ab6ed

Fix license header on patch + add CMake condition for AWS patch

b875632

Update configure.win to remove specific AWS CPP libs

6bb2000

amoeba reviewed Dec 23, 2024

View reviewed changes

r/configure.win Outdated Show resolved Hide resolved

amoeba reviewed Dec 23, 2024

View reviewed changes

r/configure.win Outdated Show resolved Hide resolved

Update r/configure.win

80501c7

Co-authored-by: Bryce Mecum <[email protected]>

amoeba reviewed Dec 23, 2024

View reviewed changes

r/configure.win Outdated Show resolved Hide resolved

Update r/configure.win

1da91c0

nealrichardson reviewed Dec 24, 2024

View reviewed changes

amoeba reviewed Dec 24, 2024

View reviewed changes

ci/scripts/PKGBUILD Outdated Show resolved Hide resolved

Test turning ccache back on

cbc1c4e

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GH-44950: [C++] Bump minimum CMake version to 3.25 #44989

GH-44950: [C++] Bump minimum CMake version to 3.25 #44989

raulcd commented Dec 10, 2024 •

edited by github-actions bot

Loading

github-actions bot commented Dec 10, 2024

raulcd commented Dec 10, 2024 •

edited

Loading

h-vetinari commented Dec 11, 2024

raulcd commented Dec 11, 2024

assignUser commented Dec 11, 2024 •

edited

Loading

nealrichardson commented Dec 11, 2024

nealrichardson commented Dec 11, 2024

pitrou commented Dec 11, 2024 •

edited

Loading

nealrichardson commented Dec 11, 2024 •

edited

Loading

jonkeane Dec 12, 2024

jonkeane Dec 13, 2024 •

edited

Loading

raulcd commented Dec 19, 2024

nealrichardson commented Dec 19, 2024

amoeba commented Dec 20, 2024

amoeba commented Dec 23, 2024

amoeba commented Dec 23, 2024

raulcd commented Dec 23, 2024

amoeba commented Dec 23, 2024

raulcd commented Dec 23, 2024

nealrichardson left a comment

nealrichardson Dec 24, 2024

nealrichardson Dec 24, 2024

nealrichardson Dec 24, 2024

nealrichardson Dec 24, 2024

amoeba Dec 24, 2024

nealrichardson Dec 24, 2024

nealrichardson Dec 24, 2024

	# AWS specific libs for Windows are bundled
	# We build aws-sdk-cpp bundled now, so the AWS libs are included in arrow_bundled_dependencies
	# but we also need to include these Windows system libraries

		@@ -83,7 +81,7 @@ build() {
		# segfaults in tests

		MSYS2_ARG_CONV_EXCL="-DCMAKE_INSTALL_PREFIX=" \

GH-44950: [C++] Bump minimum CMake version to 3.25 #44989

Are you sure you want to change the base?

GH-44950: [C++] Bump minimum CMake version to 3.25 #44989

Conversation

raulcd commented Dec 10, 2024 • edited by github-actions bot Loading

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

github-actions bot commented Dec 10, 2024

raulcd commented Dec 10, 2024 • edited Loading

h-vetinari commented Dec 11, 2024

raulcd commented Dec 11, 2024

assignUser commented Dec 11, 2024 • edited Loading

nealrichardson commented Dec 11, 2024

nealrichardson commented Dec 11, 2024

pitrou commented Dec 11, 2024 • edited Loading

nealrichardson commented Dec 11, 2024 • edited Loading

Choose a reason for hiding this comment

jonkeane Dec 13, 2024 • edited Loading

Choose a reason for hiding this comment

raulcd commented Dec 19, 2024

nealrichardson commented Dec 19, 2024

amoeba commented Dec 20, 2024

amoeba commented Dec 23, 2024

amoeba commented Dec 23, 2024

raulcd commented Dec 23, 2024

amoeba commented Dec 23, 2024

raulcd commented Dec 23, 2024

nealrichardson left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

raulcd commented Dec 10, 2024 •

edited by github-actions bot

Loading

raulcd commented Dec 10, 2024 •

edited

Loading

assignUser commented Dec 11, 2024 •

edited

Loading

pitrou commented Dec 11, 2024 •

edited

Loading

nealrichardson commented Dec 11, 2024 •

edited

Loading

jonkeane Dec 13, 2024 •

edited

Loading