Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] Include path in the documentation is wrong #45027

Closed
avitase opened this issue Dec 13, 2024 · 3 comments
Closed

[C++] Include path in the documentation is wrong #45027

avitase opened this issue Dec 13, 2024 · 3 comments
Assignees
@avitase
Labels
Component: C++ Type: bug
Milestone
19.0.0

Comments

@avitase
Copy link
Contributor

avitase commented Dec 13, 2024 •
edited
Loading

Describe the bug, including details regarding any error messages, version, and platform.

On my machine the include path for parquet is parquet/arrow/... and not arrow/parquet/arrow/.... This looks like a copy & paste bug from the line above:

arrow/cpp/examples/arrow/parquet_read_write.cc

Line 29 in 313d11a

// #include "arrow/parquet/arrow/reader.h"

arrow/cpp/examples/arrow/parquet_read_write.cc

Line 47 in 313d11a

// #include "arrow/parquet/arrow/reader.h"

Component(s)

C++
@kou kou changed the title Include path in the documentation is wrong [C++] Include path in the documentation is wrong Dec 14, 2024
@kou
Copy link
Member

kou commented Dec 14, 2024

Good catch!
Could you open a PR that fixes this?

@github-actions github-actions bot mentioned this issue Dec 15, 2024
Merged
@avitase
Copy link
Contributor Author

avitase commented Dec 15, 2024

@kou, see #45031

kou pushed a commit that referenced this issue Dec 16, 2024
@avitase
GH-45027: [C++] Include path in the documentation is wrong (#45031)
da3c6dd 
In the comments the includes of `(arrow/)parquet/arrow/reader.h` were broken. Removing the prefix `arrow` makes this include in line with the includes used at the top of the file.
* GitHub Issue: #45027

Authored-by: Nis Meinert <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
@kou
Copy link
Member

kou commented Dec 16, 2024

Issue resolved by pull request 45031
#45031

@kou kou added this to the 19.0.0 milestone Dec 16, 2024
@kou kou closed this as completed Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@avitase avitase

Labels
Component: C++ Type: bug
Projects
None yet
Milestone
19.0.0
Development

No branches or pull requests
2 participants
@kou @avitase