Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Do not merge] Change Reify.asIterable to GBK in BigQueryIO File loads #33284

Closed
wants to merge 1 commit into from

Conversation

Abacn
Copy link
Contributor

@Abacn Abacn commented Dec 4, 2024

test only

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@Abacn
Copy link
Contributor Author

Abacn commented Dec 4, 2024

Instruction to patch

To compile, need java11 and git in your bash.

Checkout the project:

git clone https://github.com/apache/beam.git --depth=1

cd beam

git fetch origin pull/33284/head:pr-33284

git switch pr-33284

git log # confirm current branch is on this patch

./gradlew -Ppublishing -p sdks/java/io/google-cloud-platform publishToMavenLocal

# check the jar published into your maven local repo

ls -l ~/.m2/repository/org/apache/beam/beam-sdks-java-io-google-cloud-platform/2.61.0-SNAPSHOT/

# -rw-r--r--  1 ...  2620623 Dec  4 16:31 beam-sdks-java-io-google-cloud-platform-2.61.0-SNAPSHOT.jar

Then in the pom.xml (for maven) or build.gradle (for gradle) project for the pipeline, change the version of org.apache.beam:beam-sdks-java-io-google-cloud-platform from 2.61.0 to 2.61.0-SNAPSHOT

UPDATE:

probably there is one more step need the change take effect, that is to add mavenLocal to the repository of your project.

For maven, it should uses the mavanLocal by default.

For gradle:

# in build.gradle

repositories {
    mavenCentral()
    mavenLocal()
}

@Abacn
Copy link
Contributor Author

Abacn commented Dec 4, 2024

note - there is a single test failing - testWriteEmptyPCollection[0] due to that the table won't get created by switching from ReifyAsIterable to GBK to combine list of files. The former will emit an empty list, while the later does not.

@Abacn Abacn closed this Jan 14, 2025
@Abacn
Copy link
Contributor Author

Abacn commented Jan 14, 2025

superceded by #33587, which is based on master branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant