Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add support for Iceberg table identifiers with special characters (#33293)" #33575

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

Abacn
Copy link
Contributor

@Abacn Abacn commented Jan 13, 2025

Reason: performance regression caught by internal tests (Iceberg write spends 100% more time)

image

half of time spends on IcebergUtils.parseTableIdentifier.

The code path suggests OBJECT_MAPPER.readTree always throws in my test case, and wasted most of time to assemble Exception object.

In general using try {} catch {} for what if clause does is an antipattern.

Possible forward fix could be using a cache.

This reverts commit d6e0b0c.

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@Abacn
Copy link
Contributor Author

Abacn commented Jan 13, 2025

R: @ahmedabu98

cc: @regadas

A forward fix could be

  • Avoid try {} catch {} thus avoid expensive Exception construction

  • Use a cache in table identifiers parsing so it won't need to be called every time

Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@regadas
Copy link
Contributor

regadas commented Jan 13, 2025

Hi @Abacn ouch, yeah adding cache makes sense to me! Can we avoid the revert if I put up a quick PR with it? Thx!

@Abacn
Copy link
Contributor Author

Abacn commented Jan 13, 2025

@regadas thanks for prompt reply. Please do not worry about revert PR, it's just a generic practice to keep HEAD clean and keep linear history. Add it back is just a matter of another commit.

Since #33293 is approved before I expect a forward fix PR can be reviewed much faster than the original PR. Take your time on fix and feel free to pin us if you have any question

Copy link
Contributor

@ahmedabu98 ahmedabu98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Abacn Abacn merged commit bb2e0ad into apache:master Jan 14, 2025
22 checks passed
@Abacn Abacn deleted the rv-33293 branch January 14, 2025 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants