Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable PreCommit Flink Container #33956

Merged
merged 3 commits into from
Feb 11, 2025
Merged

Disable PreCommit Flink Container #33956

merged 3 commits into from
Feb 11, 2025

Conversation

Abacn
Copy link
Contributor

@Abacn Abacn commented Feb 11, 2025

This test leaks Dataproc VM instance, causing GCP project drains quota.

It also does not test the PR change as it runs on snapshot images e.g. gcr.io/apache-beam-testing/beam-sdk/beam_go_sdk:latest gcr.io/apache-beam-testing/beam_portability/beam_flink1.17_job_server:latest (#33942)

Until both issues are resolved, we have to disable this test to avoid continued outage of testing infrastructure.

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions github-actions bot added the build label Feb 11, 2025
@Abacn
Copy link
Contributor Author

Abacn commented Feb 11, 2025

image

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Abacn Abacn merged commit 7ac5bc4 into apache:master Feb 11, 2025
4 checks passed
@Abacn Abacn deleted the disable-flink branch February 11, 2025 21:45
@Abacn
Copy link
Contributor Author

Abacn commented Feb 11, 2025

for resource leak issue, add "beam-precommit-flink-container" to https://github.com/apache/beam/blob/master/.test-infra/dataproc/cleanup.sh should resolve.

Abacn added a commit to Abacn/beam that referenced this pull request Feb 11, 2025
Abacn added a commit that referenced this pull request Feb 11, 2025
* Revert "Disable PreCommit Flink Container (#33956)"

This reverts commit 7ac5bc4.

* Fix clean up scripts

* Fix trigger paths

* Fix script
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants