From 9bd7480350845fc405c7c5dffa5da6a02ae65a5a Mon Sep 17 00:00:00 2001 From: Angerszhuuuu Date: Thu, 27 Jul 2023 14:27:41 +0800 Subject: [PATCH] [CELEBORN-844] Fix incorrect config name in ConfigEntity checkvalue method --- .../apache/celeborn/common/CelebornConf.scala | 20 +++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala b/common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala index 5480c7de054..196a3cfcfac 100644 --- a/common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala +++ b/common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala @@ -1559,7 +1559,7 @@ object CelebornConf extends Logging { .version("0.2.0") .doc("Port for master to bind.") .intConf - .checkValue(p => p >= 1024 && p < 65535, "invalid port") + .checkValue(p => p >= 1024 && p < 65535, "Invalid port") .createWithDefault(9097) val HA_ENABLED: ConfigEntry[Boolean] = @@ -1596,7 +1596,7 @@ object CelebornConf extends Logging { .doc("Port to bind of master node in HA mode.") .version("0.3.0") .intConf - .checkValue(p => p >= 1024 && p < 65535, "invalid port") + .checkValue(p => p >= 1024 && p < 65535, "Invalid port") .createWithDefault(9097) val HA_MASTER_NODE_RATIS_HOST: OptionalConfigEntry[String] = @@ -1617,7 +1617,7 @@ object CelebornConf extends Logging { .doc("Ratis port to bind of master node in HA mode.") .version("0.3.0") .intConf - .checkValue(p => p >= 1024 && p < 65535, "invalid port") + .checkValue(p => p >= 1024 && p < 65535, "Invalid port") .createWithDefault(9872) val HA_MASTER_RATIS_RPC_TYPE: ConfigEntry[String] = @@ -2381,7 +2381,7 @@ object CelebornConf extends Logging { "sorter memory, partition sorter will stop sorting.") .version("0.2.0") .doubleConf - .checkValue(v => v >= 0.0 && v <= 1.0, "should be in [0.0, 1.0].") + .checkValue(v => v >= 0.0 && v <= 1.0, "Should be in [0.0, 1.0].") .createWithDefault(0.1) val WORKER_DIRECT_MEMORY_RATIO_FOR_READ_BUFFER: ConfigEntry[Double] = @@ -2800,7 +2800,7 @@ object CelebornConf extends Logging { .version("0.3.0") .doc(s"Timeout for a task to push data rpc message. This value should better be more than twice of `${PUSH_TIMEOUT_CHECK_INTERVAL.key}`") .timeConf(TimeUnit.MILLISECONDS) - .checkValue(_ > 0, "celeborn.client.push.data.timeout must be positive!") + .checkValue(_ > 0, "Value must be positive!") .createWithDefaultString("120s") val TEST_CLIENT_PUSH_PRIMARY_DATA_TIMEOUT: ConfigEntry[Boolean] = @@ -3196,7 +3196,7 @@ object CelebornConf extends Logging { .doc("Max retry times for requestCommitFiles RPC.") .version("0.3.0") .intConf - .checkValue(v => v > 0, "value must be positive") + .checkValue(v => v > 0, "Value must be positive") .createWithDefault(4) val CLIENT_COMMIT_IGNORE_EXCLUDED_WORKERS: ConfigEntry[Boolean] = @@ -3404,7 +3404,7 @@ object CelebornConf extends Logging { .doc("It controls if Celeborn collect timer metrics for some operations. Its value should be in [0.0, 1.0].") .version("0.2.0") .doubleConf - .checkValue(v => v >= 0.0 && v <= 1.0, "should be in [0.0, 1.0].") + .checkValue(v => v >= 0.0 && v <= 1.0, "Should be in [0.0, 1.0].") .createWithDefault(1.0) val METRICS_SLIDING_WINDOW_SIZE: ConfigEntry[Int] = @@ -3447,7 +3447,7 @@ object CelebornConf extends Logging { .doc("Master's Prometheus port.") .version("0.3.0") .intConf - .checkValue(p => p >= 1024 && p < 65535, "invalid port") + .checkValue(p => p >= 1024 && p < 65535, "Invalid port") .createWithDefault(9098) val WORKER_PROMETHEUS_HOST: ConfigEntry[String] = @@ -3466,7 +3466,7 @@ object CelebornConf extends Logging { .doc("Worker's Prometheus port.") .version("0.3.0") .intConf - .checkValue(p => p >= 1024 && p < 65535, "invalid port") + .checkValue(p => p >= 1024 && p < 65535, "Invalid port") .createWithDefault(9096) val METRICS_EXTRA_LABELS: ConfigEntry[Seq[String]] = @@ -3577,7 +3577,7 @@ object CelebornConf extends Logging { .version("0.3.0") .doc("Vector batch size for columnar shuffle.") .intConf - .checkValue(v => v > 0, "value must be positive") + .checkValue(v => v > 0, "Value must be positive") .createWithDefault(10000) val COLUMNAR_SHUFFLE_OFF_HEAP_ENABLED: ConfigEntry[Boolean] =