[CELEBORN-883][WORKER] Optimized configuration checks during MemoryManager initialization #1801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nager initialization
Codecov Report
@@ Coverage Diff @@
## main #1801 +/- ##
==========================================
- Coverage 46.76% 46.75% -0.01%
==========================================
Files 162 162
Lines 10077 10078 +1
Branches 927 927
==========================================
- Hits 4712 4711 -1
- Misses 5058 5059 +1
- Partials 307 308 +1
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
pan3793
reviewed
Aug 10, 2023
| @@ -2450,7 +2450,8 @@ object CelebornConf extends Logging { | |||
| val WORKER_DIRECT_MEMORY_RATIO_PAUSE_REPLICATE: ConfigEntry[Double] = | |||
| buildConf("celeborn.worker.directMemoryRatioToPauseReplicate") | |||
| .categories("worker") | |||
| .doc("If direct memory usage reaches this limit, the worker will stop to receive replication data from other workers.") | |||
| .doc("If direct memory usage reaches this limit, the worker will stop to receive replication data from other workers." + | |||
There was a problem hiding this comment.
Suggested change
| .doc("If direct memory usage reaches this limit, the worker will stop to receive replication data from other workers." + | |
| .doc("If direct memory usage reaches this limit, the worker will stop to receive replication data from other workers. " + |
pan3793
reviewed
Aug 10, 2023
| Preconditions.checkArgument( | ||
| pauseReplicateRatio > pausePushDataRatio, | ||
| String.format( | ||
| "Invalid config, {} should be greater than {}", |
There was a problem hiding this comment.
let's also mention the value in the error message
Suggested change
| "Invalid config, {} should be greater than {}", | |
| "Invalid config, {}({}) should be greater than {}({})", |
pan3793
reviewed
Aug 10, 2023
|
|
||
| import org.apache.celeborn.common.CelebornConf; | ||
|
|
||
| public class MemoryManagerSuiteJ { |
There was a problem hiding this comment.
scala is preferred for brand new testing
pan3793
approved these changes
Aug 10, 2023
|
thanks, merge to main |
waitinfuture
pushed a commit
that referenced
this pull request
Aug 23, 2023
…nager initialization <!-- Thanks for sending a pull request! Here are some tips for you: - Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'. - Be sure to keep the PR description updated to reflect all changes. - Please write your PR title to summarize what this PR proposes. - If possible, provide a concise example to reproduce the issue for a faster review. --> ### What changes were proposed in this pull request? 1. Expose the config check logic during `MemoryManager#initialization` in the user configuration doc. 2. Add Preconditions Error Message 3. Add unit test to make sure that part of the logic isn't altered by mistake ### Why are the changes needed? User-friendly ### Does this PR introduce _any_ user-facing change? Yes ### How was this patch tested? Add Unit Test Closes #1801 from zwangsheng/CELEBORN-883. Authored-by: zwangsheng <[email protected]> Signed-off-by: zwangsheng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
MemoryManager#initializationin the user configuration doc.Why are the changes needed?
User-friendly
Does this PR introduce any user-facing change?
Yes
How was this patch tested?
Add Unit Test